From: Pedro Alves <palves@redhat.com>
To: Yao Qi <yao@codesourcery.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 0/7] Import needed gnulib modules explicitly
Date: Fri, 21 Nov 2014 12:50:00 -0000 [thread overview]
Message-ID: <546F34F6.10507@redhat.com> (raw)
In-Reply-To: <87fvdcg45d.fsf@codesourcery.com>
On 11/21/2014 11:54 AM, Yao Qi wrote:
> Yao Qi <yao@codesourcery.com> writes:
>
>> I go through all imported gnulib modules, and update update-gnulib.sh to
>> import modules used by GDB explicitly. This is what this patch series
>> is doing. Beside this, this patch series (patch 3 and patch 6) adjusts
>> code to not check header and api and use them directly.
>
> Although this patch series is a code refactor, patch 3 and patch 6 still
> do some non-refactor changes, so a review to them will be great.
Somehow, I didn't notice this thread at all until now. :-(
I send a few comments, but overall this looks good to me.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2014-11-21 12:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-15 13:20 Yao Qi
2014-11-15 13:20 ` [PATCH 2/7] Import alloca explicitly Yao Qi
2014-11-15 13:20 ` [PATCH 1/7] Make IMPORTED_GNULIB_MODULES in alphabetical order Yao Qi
2014-11-21 12:21 ` Pedro Alves
2014-11-15 13:20 ` [PATCH 6/7] Include wchar.h and wctype.h unconditionally Yao Qi
2014-11-21 12:49 ` Pedro Alves
2014-11-21 13:22 ` Yao Qi
2014-11-15 13:20 ` [PATCH 5/7] Import wchar and wctype-h explicitly Yao Qi
2014-11-15 13:20 ` [PATCH 3/7] Include alloca.h unconditionally Yao Qi
2014-11-21 12:21 ` Pedro Alves
2014-11-21 13:05 ` Yao Qi
2014-11-21 13:17 ` Pedro Alves
2014-11-15 13:20 ` [PATCH 4/7] Import memchr explicitly Yao Qi
2014-11-15 13:20 ` [PATCH 7/7] Import errno explicitly Yao Qi
2014-11-21 11:54 ` [PATCH 0/7] Import needed gnulib modules explicitly Yao Qi
2014-11-21 12:50 ` Pedro Alves [this message]
2014-11-21 14:06 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546F34F6.10507@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox