From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19824 invoked by alias); 21 Nov 2014 12:50:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19813 invoked by uid 89); 21 Nov 2014 12:50:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 21 Nov 2014 12:50:05 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sALCo0nq014061 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 21 Nov 2014 07:50:01 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sALCnxin004110; Fri, 21 Nov 2014 07:49:59 -0500 Message-ID: <546F34F6.10507@redhat.com> Date: Fri, 21 Nov 2014 12:50:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: Yao Qi , gdb-patches@sourceware.org Subject: Re: [PATCH 0/7] Import needed gnulib modules explicitly References: <1416057612-16155-1-git-send-email-yao@codesourcery.com> <87fvdcg45d.fsf@codesourcery.com> In-Reply-To: <87fvdcg45d.fsf@codesourcery.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-11/txt/msg00513.txt.bz2 On 11/21/2014 11:54 AM, Yao Qi wrote: > Yao Qi writes: > >> I go through all imported gnulib modules, and update update-gnulib.sh to >> import modules used by GDB explicitly. This is what this patch series >> is doing. Beside this, this patch series (patch 3 and patch 6) adjusts >> code to not check header and api and use them directly. > > Although this patch series is a code refactor, patch 3 and patch 6 still > do some non-refactor changes, so a review to them will be great. Somehow, I didn't notice this thread at all until now. :-( I send a few comments, but overall this looks good to me. Thanks, Pedro Alves