From: Pedro Alves <palves@redhat.com>
To: "Metzger, Markus T" <markus.t.metzger@intel.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH 02/12] btrace: add format argument to supports_btrace
Date: Fri, 14 Nov 2014 13:36:00 -0000 [thread overview]
Message-ID: <5466056E.5060202@redhat.com> (raw)
In-Reply-To: <A78C989F6D9628469189715575E55B231E673C5C@IRSMSX104.ger.corp.intel.com>
On 11/14/2014 12:36 PM, Metzger, Markus T wrote:
>> From: Pedro Alves [mailto:palves@redhat.com]
>>> +/* Target specific branch trace information. */
>>> +struct btrace_target_info;
>>> +
>>> +/* Enumeration of btrace read types. */
>>> +
>>> +enum btrace_read_type
>>> +{
>>> + /* Send all available trace. */
>>> + BTRACE_READ_ALL,
>>> +
>>> + /* Send all available trace, if it changed. */
>>> + BTRACE_READ_NEW,
>>> +
>>> + /* Send the trace since the last request. This will fail if the trace
>>> + buffer overflowed. */
>>> + BTRACE_READ_DELTA
>>> +};
>>
>> What does "Send" mean here?
>
> It means as much as "read". It determines what trace you'll get
> when reading btrace.
> I realize it's the producer's view; it should rather be the consumer's
> view.
Ah, yeah.
> Do you want me to change it in a separate patch?
Hmm, I'm confused -- why a separate patch instead of simply
adjusting this one?
Thanks,
Pedro Alves
next prev parent reply other threads:[~2014-11-14 13:36 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-14 13:56 [PATCH 00/12] record btrace: prepare for a new trace format Markus Metzger
2014-07-14 13:56 ` [PATCH 08/12] btrace: identify cpu Markus Metzger
2014-11-05 20:47 ` Pedro Alves
2014-07-14 13:56 ` [PATCH 06/12] btrace: update btrace_compute_ftrace parameters Markus Metzger
2014-07-14 13:56 ` [PATCH 09/12] btrace: use the new cpu identifier Markus Metzger
2014-07-14 13:56 ` [PATCH 02/12] btrace: add format argument to supports_btrace Markus Metzger
2014-11-05 20:45 ` Pedro Alves
2014-11-14 12:36 ` Metzger, Markus T
2014-11-14 13:36 ` Pedro Alves [this message]
2014-11-14 13:47 ` Metzger, Markus T
2014-11-14 13:50 ` Metzger, Markus T
2014-11-14 13:50 ` Pedro Alves
2014-07-14 13:57 ` [PATCH 05/12] record-btrace: add bts buffer size configuration option Markus Metzger
2014-07-14 15:44 ` Eli Zaretskii
2014-11-05 20:46 ` Pedro Alves
2014-07-14 13:57 ` [PATCH 04/12] record btrace: add configuration struct Markus Metzger
2014-07-14 15:06 ` Eli Zaretskii
2014-11-05 20:45 ` Pedro Alves
2014-07-14 13:57 ` [PATCH 11/12] configure: check for libipt Markus Metzger
2014-07-14 13:57 ` [PATCH 12/12] [wip] btrace: support Intel(R) Processor Trace Markus Metzger
2014-07-14 13:57 ` [PATCH 10/12] record-btrace: indicate gaps Markus Metzger
2014-07-14 13:57 ` [PATCH 07/12] btrace: extend struct btrace_insn Markus Metzger
2014-11-05 20:46 ` Pedro Alves
2014-07-14 13:57 ` [PATCH 03/12] btrace, linux: add perf event buffer abstraction Markus Metzger
2014-07-14 14:48 ` [PATCH 01/12] btrace: add struct btrace_data Markus Metzger
2014-11-05 20:44 ` Pedro Alves
2014-10-28 14:35 ` [PATCH 00/12] record btrace: prepare for a new trace format Metzger, Markus T
2014-11-05 20:50 ` Pedro Alves
2014-11-06 9:04 ` Metzger, Markus T
2014-11-07 11:27 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5466056E.5060202@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=markus.t.metzger@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox