Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Markus Metzger <markus.t.metzger@intel.com>
To: palves@redhat.com
Cc: gdb-patches@sourceware.org
Subject: [PATCH 09/12] btrace: use the new cpu identifier
Date: Mon, 14 Jul 2014 13:56:00 -0000	[thread overview]
Message-ID: <1405346196-1804-10-git-send-email-markus.t.metzger@intel.com> (raw)
In-Reply-To: <1405346196-1804-1-git-send-email-markus.t.metzger@intel.com>

The preceding patch added a cpu identifier.  Use it.

2014-07-14  Markus Metzger  <markus.t.metzger@intel.com>

	* common/linux-btrace.c: Remove include i386-cpuid.h.
	(intel_supports_bts): Update parameters.
	(cpu_supports_bts): Call btrace_this_cpu.


---
 gdb/nat/linux-btrace.c | 36 +++++++++++++-----------------------
 1 file changed, 13 insertions(+), 23 deletions(-)

diff --git a/gdb/nat/linux-btrace.c b/gdb/nat/linux-btrace.c
index 628358f..b52106e 100644
--- a/gdb/nat/linux-btrace.c
+++ b/gdb/nat/linux-btrace.c
@@ -31,7 +31,6 @@
 #include "regcache.h"
 #include "gdbthread.h"
 #include "gdb_wait.h"
-#include "i386-cpuid.h"
 
 #ifdef HAVE_SYS_SYSCALL_H
 #include <sys/syscall.h>
@@ -405,22 +404,12 @@ kernel_supports_bts (void)
 /* Check whether an Intel cpu supports BTS.  */
 
 static int
-intel_supports_bts (void)
+intel_supports_bts (const struct btrace_cpu *cpu)
 {
-  unsigned int cpuid, model, family;
-
-  if (!i386_cpuid (1, &cpuid, NULL, NULL, NULL))
-    return 0;
-
-  family = (cpuid >> 8) & 0xf;
-  model = (cpuid >> 4) & 0xf;
-
-  switch (family)
+  switch (cpu->family)
     {
     case 0x6:
-      model += (cpuid >> 12) & 0xf0;
-
-      switch (model)
+      switch (cpu->model)
 	{
 	case 0x1a: /* Nehalem */
 	case 0x1f:
@@ -448,17 +437,18 @@ intel_supports_bts (void)
 static int
 cpu_supports_bts (void)
 {
-  unsigned int ebx, ecx, edx;
+  struct btrace_cpu cpu;
 
-  if (!i386_cpuid (0, NULL, &ebx, &ecx, &edx))
-    return 0;
-
-  if (ebx == signature_INTEL_ebx && ecx == signature_INTEL_ecx
-      && edx == signature_INTEL_edx)
-    return intel_supports_bts ();
+  cpu = btrace_this_cpu ();
+  switch (cpu.vendor)
+    {
+    default:
+      /* Don't know about others.  Let's assume they do.  */
+      return 1;
 
-  /* Don't know about others.  Let's assume they do.  */
-  return 1;
+    case CV_INTEL:
+      return intel_supports_bts (&cpu);
+    }
 }
 
 /* Check whether the linux target supports BTS.  */
-- 
1.8.3.1


  parent reply	other threads:[~2014-07-14 13:56 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-14 13:56 [PATCH 00/12] record btrace: prepare for a new trace format Markus Metzger
2014-07-14 13:56 ` [PATCH 02/12] btrace: add format argument to supports_btrace Markus Metzger
2014-11-05 20:45   ` Pedro Alves
2014-11-14 12:36     ` Metzger, Markus T
2014-11-14 13:36       ` Pedro Alves
2014-11-14 13:47         ` Metzger, Markus T
2014-11-14 13:50           ` Pedro Alves
2014-11-14 13:50           ` Metzger, Markus T
2014-07-14 13:56 ` Markus Metzger [this message]
2014-07-14 13:56 ` [PATCH 06/12] btrace: update btrace_compute_ftrace parameters Markus Metzger
2014-07-14 13:56 ` [PATCH 08/12] btrace: identify cpu Markus Metzger
2014-11-05 20:47   ` Pedro Alves
2014-07-14 13:57 ` [PATCH 07/12] btrace: extend struct btrace_insn Markus Metzger
2014-11-05 20:46   ` Pedro Alves
2014-07-14 13:57 ` [PATCH 03/12] btrace, linux: add perf event buffer abstraction Markus Metzger
2014-07-14 13:57 ` [PATCH 10/12] record-btrace: indicate gaps Markus Metzger
2014-07-14 13:57 ` [PATCH 12/12] [wip] btrace: support Intel(R) Processor Trace Markus Metzger
2014-07-14 13:57 ` [PATCH 11/12] configure: check for libipt Markus Metzger
2014-07-14 13:57 ` [PATCH 04/12] record btrace: add configuration struct Markus Metzger
2014-07-14 15:06   ` Eli Zaretskii
2014-11-05 20:45   ` Pedro Alves
2014-07-14 13:57 ` [PATCH 05/12] record-btrace: add bts buffer size configuration option Markus Metzger
2014-07-14 15:44   ` Eli Zaretskii
2014-11-05 20:46   ` Pedro Alves
2014-07-14 14:48 ` [PATCH 01/12] btrace: add struct btrace_data Markus Metzger
2014-11-05 20:44   ` Pedro Alves
2014-10-28 14:35 ` [PATCH 00/12] record btrace: prepare for a new trace format Metzger, Markus T
2014-11-05 20:50   ` Pedro Alves
2014-11-06  9:04     ` Metzger, Markus T
2014-11-07 11:27       ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1405346196-1804-10-git-send-email-markus.t.metzger@intel.com \
    --to=markus.t.metzger@intel.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox