Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Simon Marchi <simon.marchi@ericsson.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] tui: Fix newterm call for older ncurses
Date: Tue, 04 Nov 2014 19:08:00 -0000	[thread overview]
Message-ID: <5459241C.4000202@redhat.com> (raw)
In-Reply-To: <1415107885-18095-1-git-send-email-simon.marchi@ericsson.com>

On 11/04/2014 01:31 PM, Simon Marchi wrote:
> Older versions of ncurses' newterm can't take NULL for their ofp and ifp
> parameters. Newer versions can, and they fall back on stdout/stdin if
> that is the case.
> 
> This patch explicitely passes stdout/stdin to the call to newterm to

"explicitly"

> avoid segfaulting with older ncurses.
> 
> Reference: https://sourceware.org/ml/gdb-patches/2014-11/msg00055.html
> 

OK.

> gdb/Changelog:
> 
> 2014-11-04  Simon Marchi  <simon.marchi@ericsson.com>
> 
> 	* tui/tui.c (tui_enable): Pass pass stdout and stdin to newterm.

Double "pass".

Thanks,
Pedro Alves


  reply	other threads:[~2014-11-04 19:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-04 13:31 Simon Marchi
2014-11-04 19:08 ` Pedro Alves [this message]
2014-11-04 19:17   ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5459241C.4000202@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@ericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox