From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9999 invoked by alias); 4 Nov 2014 19:08:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9989 invoked by uid 89); 4 Nov 2014 19:08:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 04 Nov 2014 19:08:19 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sA4J8EVp032553 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 4 Nov 2014 14:08:14 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sA4J8CtU026571; Tue, 4 Nov 2014 14:08:13 -0500 Message-ID: <5459241C.4000202@redhat.com> Date: Tue, 04 Nov 2014 19:08:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH] tui: Fix newterm call for older ncurses References: <1415107885-18095-1-git-send-email-simon.marchi@ericsson.com> In-Reply-To: <1415107885-18095-1-git-send-email-simon.marchi@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-11/txt/msg00079.txt.bz2 On 11/04/2014 01:31 PM, Simon Marchi wrote: > Older versions of ncurses' newterm can't take NULL for their ofp and ifp > parameters. Newer versions can, and they fall back on stdout/stdin if > that is the case. > > This patch explicitely passes stdout/stdin to the call to newterm to "explicitly" > avoid segfaulting with older ncurses. > > Reference: https://sourceware.org/ml/gdb-patches/2014-11/msg00055.html > OK. > gdb/Changelog: > > 2014-11-04 Simon Marchi > > * tui/tui.c (tui_enable): Pass pass stdout and stdin to newterm. Double "pass". Thanks, Pedro Alves