Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Daniel Colascione <dancol@dancol.org>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Warn users about mismatched PID namespaces
Date: Thu, 30 Oct 2014 12:23:00 -0000	[thread overview]
Message-ID: <54522DC7.2090100@redhat.com> (raw)
In-Reply-To: <5451AB7E.40709@dancol.org>

On 10/30/2014 03:07 AM, Daniel Colascione wrote:

> diff --git a/gdb/linux-thread-db.c b/gdb/linux-thread-db.c
> index 352fac1..4089417 100644
> - --- a/gdb/linux-thread-db.c
> +++ b/gdb/linux-thread-db.c
> @@ -1223,6 +1223,25 @@ thread_db_new_objfile (struct objfile *objfile)
>  static void
>  thread_db_inferior_created (struct target_ops *target, int from_tty)
>  {
> +  /* If the child is in a different PID namespace, its idea of its PID
> +     will differ from our idea of its PID.  When we scan the child's
> +     thread list, we'll mistakenly think it has no threads since the
> +     thread PID fields won't match the PID we give to
> +     libthread_db.  */

Why not give libthread_db the right PID then?

Thanks,
Pedro Alves


  reply	other threads:[~2014-10-30 12:23 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-30  3:09 Daniel Colascione
2014-10-30 12:23 ` Pedro Alves [this message]
2014-10-30 12:32   ` Daniel Colascione
2014-10-30 12:49     ` Pedro Alves
2014-10-30 12:51       ` Daniel Colascione
2014-10-30 13:12         ` Pedro Alves
2014-10-30 13:13           ` Pedro Alves
2014-10-30 15:41           ` Daniel Colascione
2014-10-30 16:18             ` Pedro Alves
2014-11-05 10:55           ` Pedro Alves
2014-11-06 21:12             ` Daniel Colascione
2014-11-07 12:50               ` Pedro Alves
2014-11-07 12:49 ` Pedro Alves
2014-11-09 21:23   ` Daniel Colascione
2014-11-11 14:25     ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54522DC7.2090100@redhat.com \
    --to=palves@redhat.com \
    --cc=dancol@dancol.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox