From: Pedro Alves <palves@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFC: gdbserver crash on win XP during watchpoint removal
Date: Wed, 15 Oct 2014 19:02:00 -0000 [thread overview]
Message-ID: <543EC4BD.5080203@redhat.com> (raw)
In-Reply-To: <20141015143501.GC25846@adacore.com>
On 10/15/2014 03:35 PM, Joel Brobecker wrote:
>>> It looks like just removing the statement that sets dr_control_mirror
>>> from the thread's DR7 is sufficient to allow hardware watchpoints
>>> to work again.
>>
>> Yes, that sounds good enough for 7.8.1. This is OK.
>
> Thanks, Pedro. I created PR server/17487 for this, and pushed
> the patch on gdb-7.8-branch using that PR.
>
>>> I admit I could have spent a little more time trying to understand
>>> the bigger picture, but I'm a bit under time pressure, so I'm hoping
>>> this is enough. Otherwise, I'll look at a better fix.
>>
>> Hmm, I've wanted to do this for a while. So... Below's is what I
>> think is the better fix.
>
> Thanks! I tested your patch on x86-windows using AdaCore's testsuite,
> and it also fixes the problem, with no regression. Do you want to push
> it?
Awesome, I pushed it in then.
> I left the PR open pending your patch going in...
Thanks,
Pedro Alves
prev parent reply other threads:[~2014-10-15 19:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-14 18:46 Joel Brobecker
2014-10-14 19:23 ` Pedro Alves
2014-10-14 21:37 ` Joel Brobecker
2014-10-15 0:38 ` Pedro Alves
2014-10-15 14:35 ` Joel Brobecker
2014-10-15 19:02 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=543EC4BD.5080203@redhat.com \
--to=palves@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox