From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4663 invoked by alias); 15 Oct 2014 19:02:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4651 invoked by uid 89); 15 Oct 2014 19:02:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 15 Oct 2014 19:02:27 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9FJ2Nx4027272 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 15 Oct 2014 15:02:24 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s9FJ2Lcq006913; Wed, 15 Oct 2014 15:02:22 -0400 Message-ID: <543EC4BD.5080203@redhat.com> Date: Wed, 15 Oct 2014 19:02:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: Joel Brobecker CC: gdb-patches@sourceware.org Subject: Re: RFC: gdbserver crash on win XP during watchpoint removal References: <20141014184647.GB8879@adacore.com> <543D782F.10506@redhat.com> <20141014213727.GA25846@adacore.com> <543DC1FF.8030109@redhat.com> <20141015143501.GC25846@adacore.com> In-Reply-To: <20141015143501.GC25846@adacore.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-10/txt/msg00408.txt.bz2 On 10/15/2014 03:35 PM, Joel Brobecker wrote: >>> It looks like just removing the statement that sets dr_control_mirror >>> from the thread's DR7 is sufficient to allow hardware watchpoints >>> to work again. >> >> Yes, that sounds good enough for 7.8.1. This is OK. > > Thanks, Pedro. I created PR server/17487 for this, and pushed > the patch on gdb-7.8-branch using that PR. > >>> I admit I could have spent a little more time trying to understand >>> the bigger picture, but I'm a bit under time pressure, so I'm hoping >>> this is enough. Otherwise, I'll look at a better fix. >> >> Hmm, I've wanted to do this for a while. So... Below's is what I >> think is the better fix. > > Thanks! I tested your patch on x86-windows using AdaCore's testsuite, > and it also fixes the problem, with no regression. Do you want to push > it? Awesome, I pushed it in then. > I left the PR open pending your patch going in... Thanks, Pedro Alves