From: Pedro Alves <palves@redhat.com>
To: Gary Benson <gbenson@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Rename current_inferior as current_thread in gdbserver
Date: Tue, 16 Sep 2014 09:34:00 -0000 [thread overview]
Message-ID: <54180437.4000404@redhat.com> (raw)
In-Reply-To: <1410345589-29648-1-git-send-email-gbenson@redhat.com>
OK, but note:
On 09/10/2014 11:39 AM, Gary Benson wrote:
> gdb/gdbserver/ChangeLog:
>
> * inferiors.h (current_inferior): Renamed as...
> (current_thread): New variable. All uses updated.
> * linux-low.c (get_pc): Renamed saved_inferior as saved_thread.
> (maybe_move_out_of_jump_pad): Likewise.
> (cancel_breakpoint): Likewise.
> (linux_low_filter_event): Likewise.
> (wait_for_sigstop): Likewise.
> (linux_resume_one_lwp): Likewise.
> (need_step_over_p): Likewise.
> (start_step_over): Likewise.
> (linux_stabilize_threads): Renamed save_inferior as saved_thread.
> * linux-x86-low.c (x86_linux_update_xmltarget): Likewise.
> * proc-service.c (ps_lgetregs): Renamed reg_inferior as reg_thread
> and save_inferior as saved_thread.
> * regcache.c (get_thread_regcache): Renamed saved_inferior as
> saved_thread.
> (regcache_invalidate_thread): Likewise.
> * remote-utils.c (prepare_resume_reply): Likewise.
> * thread-db.c (thread_db_get_tls_address): Likewise.
> (disable_thread_event_reporting): Likewise.
> (remove_thread_event_breakpoints): Likewise.
> * tracepoint.c (gdb_agent_about_to_close): Renamed save_inferior
> as saved_thread.
> ---
> gdb/gdbserver/ChangeLog | 26 +++++
> gdb/gdbserver/gdbthread.h | 2 +-
> gdb/gdbserver/inferiors.c | 12 +-
> gdb/gdbserver/inferiors.h | 4 +-
> gdb/gdbserver/linux-aarch64-low.c | 6 +-
> gdb/gdbserver/linux-arm-low.c | 14 ++--
> gdb/gdbserver/linux-cris-low.c | 2 +-
> gdb/gdbserver/linux-crisv32-low.c | 10 +-
> gdb/gdbserver/linux-low.c | 210 ++++++++++++++++++------------------
> gdb/gdbserver/linux-mips-low.c | 10 +-
> gdb/gdbserver/linux-nios2-low.c | 2 +-
> gdb/gdbserver/linux-s390-low.c | 2 +-
> gdb/gdbserver/linux-sparc-low.c | 2 +-
> gdb/gdbserver/linux-tile-low.c | 2 +-
> gdb/gdbserver/linux-x86-low.c | 22 ++--
> gdb/gdbserver/lynx-low.c | 16 ++--
> gdb/gdbserver/mem-break.c | 6 +-
> gdb/gdbserver/nto-low.c | 20 ++--
> gdb/gdbserver/proc-service.c | 14 ++--
> gdb/gdbserver/regcache.c | 14 ++--
> gdb/gdbserver/remote-utils.c | 14 ++--
> gdb/gdbserver/server.c | 24 ++--
> gdb/gdbserver/target.c | 4 +-
> gdb/gdbserver/tdesc.c | 2 +-
> gdb/gdbserver/thread-db.c | 22 ++--
> gdb/gdbserver/tracepoint.c | 14 ++--
> gdb/gdbserver/win32-low.c | 12 +-
> 27 files changed, 257 insertions(+), 231 deletions(-)
The ChangeLog appears incomplete.
> --- a/gdb/gdbserver/target.c
> +++ b/gdb/gdbserver/target.c
> @@ -34,9 +34,9 @@ set_desired_inferior (int use_general)
^^^^^^^^^^^^^^^^^^^^
It'd be good to rename that function too, along with the comments
in the callers. Either now or as follow up.
> found = find_thread_ptid (cont_thread);
>
> if (found == NULL)
> - current_inferior = get_first_thread ();
> + current_thread = get_first_thread ();
> else
> - current_inferior = found;
> + current_thread = found;
> }
>
Thanks,
Pedro Alves
next prev parent reply other threads:[~2014-09-16 9:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 10:40 Gary Benson
2014-09-15 15:33 ` [PING PATCH] " Gary Benson
2014-09-16 9:34 ` Pedro Alves [this message]
2014-09-16 11:13 ` [PATCH v2] " Gary Benson
2014-09-16 11:22 ` Pedro Alves
2014-09-16 15:04 ` Gary Benson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54180437.4000404@redhat.com \
--to=palves@redhat.com \
--cc=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox