From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32598 invoked by alias); 16 Sep 2014 09:34:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32579 invoked by uid 89); 16 Sep 2014 09:34:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 16 Sep 2014 09:34:51 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8G9YoGV015335 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 16 Sep 2014 05:34:50 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s8G9YmHG016080; Tue, 16 Sep 2014 05:34:49 -0400 Message-ID: <54180437.4000404@redhat.com> Date: Tue, 16 Sep 2014 09:34:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.0 MIME-Version: 1.0 To: Gary Benson CC: gdb-patches@sourceware.org Subject: Re: [PATCH] Rename current_inferior as current_thread in gdbserver References: <1410345589-29648-1-git-send-email-gbenson@redhat.com> In-Reply-To: <1410345589-29648-1-git-send-email-gbenson@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-09/txt/msg00518.txt.bz2 OK, but note: On 09/10/2014 11:39 AM, Gary Benson wrote: > gdb/gdbserver/ChangeLog: > > * inferiors.h (current_inferior): Renamed as... > (current_thread): New variable. All uses updated. > * linux-low.c (get_pc): Renamed saved_inferior as saved_thread. > (maybe_move_out_of_jump_pad): Likewise. > (cancel_breakpoint): Likewise. > (linux_low_filter_event): Likewise. > (wait_for_sigstop): Likewise. > (linux_resume_one_lwp): Likewise. > (need_step_over_p): Likewise. > (start_step_over): Likewise. > (linux_stabilize_threads): Renamed save_inferior as saved_thread. > * linux-x86-low.c (x86_linux_update_xmltarget): Likewise. > * proc-service.c (ps_lgetregs): Renamed reg_inferior as reg_thread > and save_inferior as saved_thread. > * regcache.c (get_thread_regcache): Renamed saved_inferior as > saved_thread. > (regcache_invalidate_thread): Likewise. > * remote-utils.c (prepare_resume_reply): Likewise. > * thread-db.c (thread_db_get_tls_address): Likewise. > (disable_thread_event_reporting): Likewise. > (remove_thread_event_breakpoints): Likewise. > * tracepoint.c (gdb_agent_about_to_close): Renamed save_inferior > as saved_thread. > --- > gdb/gdbserver/ChangeLog | 26 +++++ > gdb/gdbserver/gdbthread.h | 2 +- > gdb/gdbserver/inferiors.c | 12 +- > gdb/gdbserver/inferiors.h | 4 +- > gdb/gdbserver/linux-aarch64-low.c | 6 +- > gdb/gdbserver/linux-arm-low.c | 14 ++-- > gdb/gdbserver/linux-cris-low.c | 2 +- > gdb/gdbserver/linux-crisv32-low.c | 10 +- > gdb/gdbserver/linux-low.c | 210 ++++++++++++++++++------------------ > gdb/gdbserver/linux-mips-low.c | 10 +- > gdb/gdbserver/linux-nios2-low.c | 2 +- > gdb/gdbserver/linux-s390-low.c | 2 +- > gdb/gdbserver/linux-sparc-low.c | 2 +- > gdb/gdbserver/linux-tile-low.c | 2 +- > gdb/gdbserver/linux-x86-low.c | 22 ++-- > gdb/gdbserver/lynx-low.c | 16 ++-- > gdb/gdbserver/mem-break.c | 6 +- > gdb/gdbserver/nto-low.c | 20 ++-- > gdb/gdbserver/proc-service.c | 14 ++-- > gdb/gdbserver/regcache.c | 14 ++-- > gdb/gdbserver/remote-utils.c | 14 ++-- > gdb/gdbserver/server.c | 24 ++-- > gdb/gdbserver/target.c | 4 +- > gdb/gdbserver/tdesc.c | 2 +- > gdb/gdbserver/thread-db.c | 22 ++-- > gdb/gdbserver/tracepoint.c | 14 ++-- > gdb/gdbserver/win32-low.c | 12 +- > 27 files changed, 257 insertions(+), 231 deletions(-) The ChangeLog appears incomplete. > --- a/gdb/gdbserver/target.c > +++ b/gdb/gdbserver/target.c > @@ -34,9 +34,9 @@ set_desired_inferior (int use_general) ^^^^^^^^^^^^^^^^^^^^ It'd be good to rename that function too, along with the comments in the callers. Either now or as follow up. > found = find_thread_ptid (cont_thread); > > if (found == NULL) > - current_inferior = get_first_thread (); > + current_thread = get_first_thread (); > else > - current_inferior = found; > + current_thread = found; > } > Thanks, Pedro Alves