From: Pedro Alves <palves@redhat.com>
To: Patrick Palka <patrick@parcs.ath.cx>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix terminal state corruption when starting a program from within TUI
Date: Wed, 27 Aug 2014 11:41:00 -0000 [thread overview]
Message-ID: <53FDC401.30509@redhat.com> (raw)
In-Reply-To: <1408990671-6023-1-git-send-email-patrick@parcs.ath.cx>
On 08/25/2014 07:17 PM, Patrick Palka wrote:
> The TUI terminal state becomes corrupted (e.g. key sequences such as
> Alt_F and Alt_B no longer work) when one attaches to an inferior process
> (via "run" or "attach") from within TUI. This terminal corruption
> remains until you switch out of TUI mode.
This has bugged me for a long while, and I simply got used to
working around it. Thanks a lot for tracking it down!
This is OK.
> gdb/ChangeLog:
> * inferior.h (child_terminal_save_ours): Rename to ...
> (gdb_save_tty_state): ... this.
Could you move this to terminal.h, right next to gdb_has_a_terminal
please ?
> * inflow.c (child_terminal_save_ours): Rename to ...
> (gdb_save_tty_state): ... this.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2014-08-27 11:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-25 18:18 Patrick Palka
2014-08-27 11:41 ` Pedro Alves [this message]
2014-08-27 12:19 ` Patrick Palka
2014-08-27 16:15 ` Sergio Durigan Junior
2014-08-27 16:21 ` Patrick Palka
2014-08-27 16:28 ` Sergio Durigan Junior
2014-08-27 16:37 ` Sergio Durigan Junior
2014-08-27 16:43 ` Patrick Palka
2014-08-27 16:50 ` Sergio Durigan Junior
2014-08-27 16:55 ` Patrick Palka
2014-08-27 17:02 ` Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FDC401.30509@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=patrick@parcs.ath.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox