From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30032 invoked by alias); 27 Aug 2014 11:41:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30012 invoked by uid 89); 27 Aug 2014 11:41:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 27 Aug 2014 11:41:57 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7RBft8N015011 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 27 Aug 2014 07:41:55 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s7RBfrBo023383; Wed, 27 Aug 2014 07:41:54 -0400 Message-ID: <53FDC401.30509@redhat.com> Date: Wed, 27 Aug 2014 11:41:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: Patrick Palka , gdb-patches@sourceware.org Subject: Re: [PATCH] Fix terminal state corruption when starting a program from within TUI References: <1408990671-6023-1-git-send-email-patrick@parcs.ath.cx> In-Reply-To: <1408990671-6023-1-git-send-email-patrick@parcs.ath.cx> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-08/txt/msg00564.txt.bz2 On 08/25/2014 07:17 PM, Patrick Palka wrote: > The TUI terminal state becomes corrupted (e.g. key sequences such as > Alt_F and Alt_B no longer work) when one attaches to an inferior process > (via "run" or "attach") from within TUI. This terminal corruption > remains until you switch out of TUI mode. This has bugged me for a long while, and I simply got used to working around it. Thanks a lot for tracking it down! This is OK. > gdb/ChangeLog: > * inferior.h (child_terminal_save_ours): Rename to ... > (gdb_save_tty_state): ... this. Could you move this to terminal.h, right next to gdb_has_a_terminal please ? > * inflow.c (child_terminal_save_ours): Rename to ... > (gdb_save_tty_state): ... this. Thanks, Pedro Alves