From: Pedro Alves <palves@redhat.com>
To: Doug Evans <dje@google.com>, Gary Benson <gbenson@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 4/4 v6] Introduce common-debug.h
Date: Wed, 20 Aug 2014 15:51:00 -0000 [thread overview]
Message-ID: <53F4C3F4.4090808@redhat.com> (raw)
In-Reply-To: <21482.43213.338533.34714@ruffy.mtv.corp.google.com>
On 08/13/2014 12:52 AM, Doug Evans wrote:
> btw, it's confusing that the variable is named "debug_hw_points"
> but the command to set it is "maint set show-debug-regs". Bleah.
> The intuitive naming is to base the variable name off of the parameter name,
> but I'm also ok with changing the parameter name.
> "set debug hw-points <n>" ?
> I don't have a strong opinion, other than if we're making changes
> in this area IWBN to clean up the naming while we're at it.
> Plus "set debug ..." is more consistent with other such parameters
> than "maint set ...".
FWIW, if I don't use this command for a while, when I need it again,
I always get confused with the set+show in "maint SET SHOW-debug-regs".
I'd +1 renaming it to "set debug something".
(TBC, I'm not suggesting that doing this now.)
Thanks,
Pedro Alves
prev parent reply other threads:[~2014-08-20 15:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-11 15:18 [PATCH 0/4 v6] Common code cleanups (first four) Gary Benson
2014-08-11 15:18 ` [PATCH 1/4 v6] Introduce common/errors.h Gary Benson
2014-08-11 15:18 ` [PATCH 3/4 v6] Move print-utils.h to common-defs.h Gary Benson
2014-08-11 15:18 ` [PATCH 2/4 v6] Introduce common-types.h Gary Benson
2014-08-11 16:17 ` [PATCH 4/4 v6] Introduce common-debug.h Gary Benson
2014-08-12 23:52 ` Doug Evans
2014-08-20 15:51 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F4C3F4.4090808@redhat.com \
--to=palves@redhat.com \
--cc=dje@google.com \
--cc=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox