From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24336 invoked by alias); 20 Aug 2014 15:51:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24324 invoked by uid 89); 20 Aug 2014 15:51:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 20 Aug 2014 15:51:22 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7KFpImu030988 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 20 Aug 2014 11:51:18 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s7KFpGkC031597; Wed, 20 Aug 2014 11:51:17 -0400 Message-ID: <53F4C3F4.4090808@redhat.com> Date: Wed, 20 Aug 2014 15:51:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Doug Evans , Gary Benson CC: gdb-patches@sourceware.org Subject: Re: [PATCH 4/4 v6] Introduce common-debug.h References: <1407770255-2589-1-git-send-email-gbenson@redhat.com> <1407770255-2589-5-git-send-email-gbenson@redhat.com> <21482.43213.338533.34714@ruffy.mtv.corp.google.com> In-Reply-To: <21482.43213.338533.34714@ruffy.mtv.corp.google.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-08/txt/msg00412.txt.bz2 On 08/13/2014 12:52 AM, Doug Evans wrote: > btw, it's confusing that the variable is named "debug_hw_points" > but the command to set it is "maint set show-debug-regs". Bleah. > The intuitive naming is to base the variable name off of the parameter name, > but I'm also ok with changing the parameter name. > "set debug hw-points " ? > I don't have a strong opinion, other than if we're making changes > in this area IWBN to clean up the naming while we're at it. > Plus "set debug ..." is more consistent with other such parameters > than "maint set ...". FWIW, if I don't use this command for a while, when I need it again, I always get confused with the set+show in "maint SET SHOW-debug-regs". I'd +1 renaming it to "set debug something". (TBC, I'm not suggesting that doing this now.) Thanks, Pedro Alves