From: Simon Marchi <simon.marchi@ericsson.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Rename variable with confusing name
Date: Wed, 06 Aug 2014 19:34:00 -0000 [thread overview]
Message-ID: <53E28348.9040607@ericsson.com> (raw)
In-Reply-To: <20140806131735.GB5204@adacore.com>
On 14-08-06 09:17 AM, Joel Brobecker wrote:
>> I saw this gem of not so legible code in solib-svr4.c (scan_dyntag):
>>
>> if (dyn_tag == dyntag)
>>
>> and thought it deserved a small rename.
>
> Indeed!
>
>> 2014-08-01 Simon Marchi <simon.marchi@ericsson.com>
>>
>> * solib-svr4.c (scan_dyntag): Rename dyntag, dyn_tag and
>> dyn_ptr variables.
>
> Approved, and many thanks for this small but important improvement.
> We also have the same issue in scan_dyntag_auxv; if you feel inclined
> to it, the same change is pre-approved there.
Thanks Joel.
Pushed with modifications to scan_dyntag_auxv as well.
next prev parent reply other threads:[~2014-08-06 19:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-01 22:09 Simon Marchi
2014-08-06 13:17 ` Joel Brobecker
2014-08-06 19:34 ` Simon Marchi [this message]
2014-08-06 19:51 ` Joel Brobecker
2014-08-06 19:53 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E28348.9040607@ericsson.com \
--to=simon.marchi@ericsson.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox