Re: [PATCH] Rename variable with confusing name

Joel Brobecker
2014-08-06T13:17:40Z

> I saw this gem of not so legible code in solib-svr4.c (scan_dyntag):
>
> if (dyn_tag == dyntag)
>
> and thought it deserved a small rename.

Indeed!

> 2014-08-01 Simon Marchi <simon.marchi@ericsson.com>
>
> * solib-svr4.c (scan_dyntag): Rename dyntag, dyn_tag and
> dyn_ptr variables.

Approved, and many thanks for this small but important improvement.
We also have the same issue in scan_dyntag_auxv; if you feel inclined
to it, the same change is pre-approved there.

--
Joel