Re: [PATCH] Rename variable with confusing name

Simon Marchi
2014-08-06T19:34:38Z

On 14-08-06 09:17 AM, Joel Brobecker wrote:
>> I saw this gem of not so legible code in solib-svr4.c (scan_dyntag):
>>
>> if (dyn_tag == dyntag)
>>
>> and thought it deserved a small rename.
>
> Indeed!
>
>> 2014-08-01 Simon Marchi <simon.marchi@ericsson.com>
>>
>> * solib-svr4.c (scan_dyntag): Rename dyntag, dyn_tag and
>> dyn_ptr variables.
>
> Approved, and many thanks for this small but important improvement.
> We also have the same issue in scan_dyntag_auxv; if you feel inclined
> to it, the same change is pre-approved there.

Thanks Joel.

Pushed with modifications to scan_dyntag_auxv as well.