Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 0/4] baby step toward multi-target
Date: Tue, 29 Jul 2014 16:32:00 -0000	[thread overview]
Message-ID: <53D7C8D8.30104@redhat.com> (raw)
In-Reply-To: <87lhrccja2.fsf@fleche.redhat.com>

On 07/29/2014 03:49 PM, Tom Tromey wrote:

> However, it's probably useful as a starting point for the next attempt
> at multi-target.  In particular it's much less invasive than the earlier
> approach, and the "convert current_target to be a pointer" patch (the
> biggest one) was mostly done with a perl one-liner.

Yeah.

Hmm, kind of orthogonal, but not really, I wonder how far are we
to getting rid of the remaining target stack annoyances.  Like:

 #1 - Convert the remaining data fields to methods.  That seems it'll
      just be boring work.
 #2 - making the debug target a wrapping target around each target layer
      (as you suggested elsewhere).  That'll require make-target-delegates
      hacking.

That'd then make it possible to:

 #3 - eliminate the squashed current_target, replacing it with a pointer
      to the topmost target in the stack (mostly the same as your
      perl one-liner).

Is that in line with what you've been thinking?  I'm wondering whether
you found out in the more invasive branch that it's useful if
current_target is more than a struct target_ops pointer ?
(or "struct target *" after vtable-ification.)

Thanks,
Pedro Alves


  reply	other threads:[~2014-07-29 16:23 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-18 19:27 Tom Tromey
2014-07-18 19:27 ` [PATCH 2/4] simplify target_is_pushed Tom Tromey
2014-07-29 13:22   ` Joel Brobecker
2014-07-29 15:16     ` Tom Tromey
2014-07-18 19:27 ` [PATCH 1/4] move core_bfd to program space Tom Tromey
2014-07-18 19:45 ` [PATCH 3/4] add to_identity Tom Tromey
2014-07-29 14:56   ` Joel Brobecker
2014-07-29 15:11     ` Tom Tromey
2014-07-18 20:44 ` [PATCH 4/4] convert corelow to to_xclose Tom Tromey
2014-07-29 15:11 ` [PATCH 0/4] baby step toward multi-target Pedro Alves
2014-07-29 15:15   ` Tom Tromey
2014-07-29 16:32     ` Pedro Alves [this message]
2014-07-29 19:04       ` Tom Tromey
2014-07-29 21:32         ` Doug Evans
2014-08-11  5:54           ` Doug Evans
2014-07-29 15:40   ` Doug Evans
2014-08-10 20:02 ` Doug Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53D7C8D8.30104@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox