From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/4] simplify target_is_pushed
Date: Tue, 29 Jul 2014 13:22:00 -0000 [thread overview]
Message-ID: <20140729124716.GB6436@adacore.com> (raw)
In-Reply-To: <1405711635-1102-3-git-send-email-tromey@redhat.com>
> While working on target_is_pushed, I noticed that it is written in a
> strange way. The code currently keeps an extra indirection, where a
> simple linked list traversal is all that is needed. It seems likely
> this was done by copying and pasting other code. However, there is no
> reason to do this and the more obvious code is simpler to reason
> about. So, this patch change the implementation.
>
> 2014-07-18 Tom Tromey <tromey@redhat.com>
>
> * target.c (target_is_pushed): Simplify.
Indeed. It looks like this one could go in on its own...
--
Joel
next prev parent reply other threads:[~2014-07-29 12:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-18 19:27 [PATCH 0/4] baby step toward multi-target Tom Tromey
2014-07-18 19:27 ` [PATCH 1/4] move core_bfd to program space Tom Tromey
2014-07-18 19:27 ` [PATCH 2/4] simplify target_is_pushed Tom Tromey
2014-07-29 13:22 ` Joel Brobecker [this message]
2014-07-29 15:16 ` Tom Tromey
2014-07-18 19:45 ` [PATCH 3/4] add to_identity Tom Tromey
2014-07-29 14:56 ` Joel Brobecker
2014-07-29 15:11 ` Tom Tromey
2014-07-18 20:44 ` [PATCH 4/4] convert corelow to to_xclose Tom Tromey
2014-07-29 15:11 ` [PATCH 0/4] baby step toward multi-target Pedro Alves
2014-07-29 15:15 ` Tom Tromey
2014-07-29 16:32 ` Pedro Alves
2014-07-29 19:04 ` Tom Tromey
2014-07-29 21:32 ` Doug Evans
2014-08-11 5:54 ` Doug Evans
2014-07-29 15:40 ` Doug Evans
2014-08-10 20:02 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140729124716.GB6436@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox