From: Yao Qi <yao@codesourcery.com>
To: Pedro Alves <palves@redhat.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix PR 17206
Date: Tue, 29 Jul 2014 07:22:00 -0000 [thread overview]
Message-ID: <53D740FA.6030600@codesourcery.com> (raw)
In-Reply-To: <53D65DA8.1000005@redhat.com>
On 07/28/2014 10:26 PM, Pedro Alves wrote:
> From a high-level perspective, the issue triggered when you did
> "until" and PC pointed somewhere we had no debug info for, and there
> was no breakpoint at PC that needed to be stepped over. That is
> main use case and code path that we didn't have a test for.
>
> Note that although it happened to be a range-stepping-related assertion
> that triggered, the code was wrong even without range-stepping. E.g.,
> if the instruction at PC is a conditional jmp to PC (like a spinlock),
> even without range-stepping, "until" should continue stepping until
> PC moves past the jump (that's the whole point of until), while
> it was stopping after one single-step, thus still pointing at the
> same PC.
>
> So I think "until-nodebug.exp" would be a good name for this test.
That is OK to me. This bug is on 7.8 branch too. The patch is pushed
to mainline and 7.8 branch. I've added it to
https://sourceware.org/gdb/wiki/GDB_7.8_Release
--
Yao (é½å°§)
prev parent reply other threads:[~2014-07-29 6:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-28 12:37 Yao Qi
2014-07-28 13:37 ` Pedro Alves
2014-07-28 14:26 ` Yao Qi
2014-07-28 14:49 ` Pedro Alves
2014-07-29 7:22 ` Yao Qi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D740FA.6030600@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox