From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26129 invoked by alias); 29 Jul 2014 06:40:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25974 invoked by uid 89); 29 Jul 2014 06:40:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 29 Jul 2014 06:40:20 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1XC156-0005gI-TF from Yao_Qi@mentor.com ; Mon, 28 Jul 2014 23:40:16 -0700 Received: from SVR-ORW-FEM-06.mgc.mentorg.com ([147.34.97.120]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Mon, 28 Jul 2014 23:40:16 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by SVR-ORW-FEM-06.mgc.mentorg.com (147.34.97.120) with Microsoft SMTP Server id 14.2.247.3; Mon, 28 Jul 2014 23:40:15 -0700 Message-ID: <53D740FA.6030600@codesourcery.com> Date: Tue, 29 Jul 2014 07:22:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Pedro Alves , Subject: Re: [PATCH] Fix PR 17206 References: <1406547056-22541-1-git-send-email-yao@codesourcery.com> <53D6441B.3050702@redhat.com> <53D6511E.3040404@codesourcery.com> <53D65DA8.1000005@redhat.com> In-Reply-To: <53D65DA8.1000005@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00712.txt.bz2 On 07/28/2014 10:26 PM, Pedro Alves wrote: > From a high-level perspective, the issue triggered when you did > "until" and PC pointed somewhere we had no debug info for, and there > was no breakpoint at PC that needed to be stepped over. That is > main use case and code path that we didn't have a test for. > > Note that although it happened to be a range-stepping-related assertion > that triggered, the code was wrong even without range-stepping. E.g., > if the instruction at PC is a conditional jmp to PC (like a spinlock), > even without range-stepping, "until" should continue stepping until > PC moves past the jump (that's the whole point of until), while > it was stopping after one single-step, thus still pointing at the > same PC. > > So I think "until-nodebug.exp" would be a good name for this test. That is OK to me. This bug is on 7.8 branch too. The patch is pushed to mainline and 7.8 branch. I've added it to https://sourceware.org/gdb/wiki/GDB_7.8_Release -- Yao (齐尧)