From: Michael Eager <eager@eagerm.com>
To: Ajit Kumar Agarwal <ajit.kumar.agarwal@xilinx.com>,
Pedro Alves <palves@redhat.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Cc: Michael Eager <eager@eagercon.com>,
Vinod Kathail <vinodk@xilinx.com>,
Vidhumouli Hunsigida <vidhum@xilinx.com>,
Nagaraju Mekala <nmekala@xilinx.com>
Subject: Re: [Patch, microblaze]: Communicate in larger blocks with the target.
Date: Thu, 24 Jul 2014 02:39:00 -0000 [thread overview]
Message-ID: <53D06F8B.5070907@eagerm.com> (raw)
In-Reply-To: <9f804e53-b4a5-4f72-9260-cdacf4fb60c5@BN1AFFO11FD045.protection.gbl>
On 06/17/14 11:12, Ajit Kumar Agarwal wrote:
> Sorry Pedro. The ChangeLog was missing. Could you please review and let me know if its okay.
>
> [Patch, microblaze]: Use target_read_code in microblaze_fetch_instruction
>
> This patch uses target_read_code instead of target_read_memory in
> microblaze_fetch instruction in order to use cache memory accesses
> requested in target_read_code.
>
> ChangeLog:
> 2014-06-17 Ajit Agarwal <ajitkum@xilinx.com>
>
> * microblaze-tdep.c (microblaze_fetch_instruction): Use of
> target_read_code.
>
> Signed-off-by:Ajit Agarwal ajitkum@xilinx.com
>
> ---
> gdb/microblaze-tdep.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/gdb/microblaze-tdep.c b/gdb/microblaze-tdep.c
> index 14c1b52..4e5b2d5 100644
> --- a/gdb/microblaze-tdep.c
> +++ b/gdb/microblaze-tdep.c
> @@ -126,7 +126,7 @@ microblaze_fetch_instruction (CORE_ADDR pc)
> gdb_byte buf[4];
>
> /* If we can't read the instruction at PC, return zero. */
> - if (target_read_memory (pc, buf, sizeof (buf)))
> + if (target_read_code (pc, buf, sizeof (buf)))
> return 0;
>
> return extract_unsigned_integer (buf, 4, byte_order);
>
Committed 3421196.
--
Michael Eager eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
next prev parent reply other threads:[~2014-07-24 2:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-17 9:03 Ajit Kumar Agarwal
2014-06-17 13:49 ` Pedro Alves
2014-06-17 16:34 ` Pedro Alves
2014-06-17 16:49 ` Ajit Kumar Agarwal
2014-06-17 16:52 ` Pedro Alves
2014-06-17 18:09 ` Ajit Kumar Agarwal
2014-06-17 18:13 ` Ajit Kumar Agarwal
2014-06-18 9:28 ` Pedro Alves
2014-07-24 2:39 ` Michael Eager [this message]
2014-06-17 14:47 ` Michael Eager
2014-06-17 16:32 ` Tom Tromey
2014-07-23 18:56 ` Michael Eager
2014-07-23 20:04 ` Michael Eager
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D06F8B.5070907@eagerm.com \
--to=eager@eagerm.com \
--cc=ajit.kumar.agarwal@xilinx.com \
--cc=eager@eagercon.com \
--cc=gdb-patches@sourceware.org \
--cc=nmekala@xilinx.com \
--cc=palves@redhat.com \
--cc=vidhum@xilinx.com \
--cc=vinodk@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox