From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12928 invoked by alias); 24 Jul 2014 02:29:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12911 invoked by uid 89); 24 Jul 2014 02:29:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-HELO: homiemail-a94.g.dreamhost.com Received: from sub5.mail.dreamhost.com (HELO homiemail-a94.g.dreamhost.com) (208.113.200.129) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 24 Jul 2014 02:29:33 +0000 Received: from homiemail-a94.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a94.g.dreamhost.com (Postfix) with ESMTP id DD66C38A06F; Wed, 23 Jul 2014 19:29:31 -0700 (PDT) Received: from redwood.eagercon.com (c-24-7-16-38.hsd1.ca.comcast.net [24.7.16.38]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: eager@eagerm.com) by homiemail-a94.g.dreamhost.com (Postfix) with ESMTPSA id 8C64D38A056; Wed, 23 Jul 2014 19:29:31 -0700 (PDT) Message-ID: <53D06F8B.5070907@eagerm.com> Date: Thu, 24 Jul 2014 02:39:00 -0000 From: Michael Eager User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Ajit Kumar Agarwal , Pedro Alves , "gdb-patches@sourceware.org" CC: Michael Eager , Vinod Kathail , Vidhumouli Hunsigida , Nagaraju Mekala Subject: Re: [Patch, microblaze]: Communicate in larger blocks with the target. References: <41df2189-0a72-4543-ba31-297f81e663d7@BN1AFFO11FD025.protection.gbl> <53A04753.5010102@redhat.com> <53A06E16.2020603@redhat.com> <6e827cdb-8f1d-4341-9891-78a471a4d14f@BY2FFO11FD033.protection.gbl> <53A07246.7010405@redhat.com> <9f804e53-b4a5-4f72-9260-cdacf4fb60c5@BN1AFFO11FD045.protection.gbl> In-Reply-To: <9f804e53-b4a5-4f72-9260-cdacf4fb60c5@BN1AFFO11FD045.protection.gbl> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00619.txt.bz2 On 06/17/14 11:12, Ajit Kumar Agarwal wrote: > Sorry Pedro. The ChangeLog was missing. Could you please review and let me know if its okay. > > [Patch, microblaze]: Use target_read_code in microblaze_fetch_instruction > > This patch uses target_read_code instead of target_read_memory in > microblaze_fetch instruction in order to use cache memory accesses > requested in target_read_code. > > ChangeLog: > 2014-06-17 Ajit Agarwal > > * microblaze-tdep.c (microblaze_fetch_instruction): Use of > target_read_code. > > Signed-off-by:Ajit Agarwal ajitkum@xilinx.com > > --- > gdb/microblaze-tdep.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/gdb/microblaze-tdep.c b/gdb/microblaze-tdep.c > index 14c1b52..4e5b2d5 100644 > --- a/gdb/microblaze-tdep.c > +++ b/gdb/microblaze-tdep.c > @@ -126,7 +126,7 @@ microblaze_fetch_instruction (CORE_ADDR pc) > gdb_byte buf[4]; > > /* If we can't read the instruction at PC, return zero. */ > - if (target_read_memory (pc, buf, sizeof (buf))) > + if (target_read_code (pc, buf, sizeof (buf))) > return 0; > > return extract_unsigned_integer (buf, 4, byte_order); > Committed 3421196. -- Michael Eager eager@eagercon.com 1960 Park Blvd., Palo Alto, CA 94306 650-325-8077