From: Pedro Alves <palves@redhat.com>
To: Stan Shebs <stanshebs@earthlink.net>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Linux: Use kill_lwp/tkill instead of kill when killing a, process
Date: Wed, 16 Jul 2014 21:58:00 -0000 [thread overview]
Message-ID: <53C6CC4B.2080600@redhat.com> (raw)
In-Reply-To: <53C5948B.9000102@earthlink.net>
On 07/15/2014 08:27 PM, Jan Kratochvil wrote:
> I do not.
> Just it is the general GDB rule of "If it ain't broken, don't fix it".
> There are various old and patched kernels out there.
Well, it's broken, because it's not using tgkill, which we should be
using everywhere instead of tkill/kill. Leaving the place that sends
SIGKILL using plain "kill" is kind of self-defeating.
If there are NPTL kernels that require "kill" for some odd reason,
then we should add some kind of detection for that, so to not punish
newer kernels. LinuxThreads will always fallback to "kill".
On 07/15/2014 09:52 PM, Stan Shebs wrote:
> But going by context, maybe kill_lwp was just overlooked at
> the time, and then propagated verbatim thereafter.
Yes, that's my theory.
I'm pushing this in then.
--
Pedro Alves
prev parent reply other threads:[~2014-07-16 19:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-15 15:55 Pedro Alves
2014-07-15 19:33 ` Jan Kratochvil
2014-07-15 21:03 ` Stan Shebs
2014-07-16 21:58 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C6CC4B.2080600@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=stanshebs@earthlink.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox