From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1517 invoked by alias); 16 Jul 2014 19:02:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1506 invoked by uid 89); 16 Jul 2014 19:02:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 16 Jul 2014 19:02:40 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s6GJ2aEn008074 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 16 Jul 2014 15:02:37 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s6GJ2ZZx032010; Wed, 16 Jul 2014 15:02:36 -0400 Message-ID: <53C6CC4B.2080600@redhat.com> Date: Wed, 16 Jul 2014 21:58:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Stan Shebs , gdb-patches@sourceware.org Subject: Re: [PATCH] Linux: Use kill_lwp/tkill instead of kill when killing a, process References: <53C54C7C.3070907@redhat.com> <20140715192749.GA32218@host2.jankratochvil.net> <53C5948B.9000102@earthlink.net> In-Reply-To: <53C5948B.9000102@earthlink.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-07/txt/msg00451.txt.bz2 On 07/15/2014 08:27 PM, Jan Kratochvil wrote: > I do not. > Just it is the general GDB rule of "If it ain't broken, don't fix it". > There are various old and patched kernels out there. Well, it's broken, because it's not using tgkill, which we should be using everywhere instead of tkill/kill. Leaving the place that sends SIGKILL using plain "kill" is kind of self-defeating. If there are NPTL kernels that require "kill" for some odd reason, then we should add some kind of detection for that, so to not punish newer kernels. LinuxThreads will always fallback to "kill". On 07/15/2014 09:52 PM, Stan Shebs wrote: > But going by context, maybe kill_lwp was just overlooked at > the time, and then propagated verbatim thereafter. Yes, that's my theory. I'm pushing this in then. -- Pedro Alves