From: Pedro Alves <palves@redhat.com>
To: Markus Metzger <markus.t.metzger@intel.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2 1/3] make_corefile_notes: have caller free returned memory
Date: Tue, 24 Jun 2014 12:58:00 -0000 [thread overview]
Message-ID: <53A9760B.2060807@redhat.com> (raw)
In-Reply-To: <1403599872-25299-1-git-send-email-markus.t.metzger@intel.com>
On 06/24/2014 09:51 AM, Markus Metzger wrote:
> The various make_corefile_notes implementations for gdbarch as well as target
> currently make an xfree cleanup on the data they return. This causes problems
> when trying to put a TRY_CATCH around the make_corefile_notes call.
> Specifically, we get a stale cleanup error in restore_my_cleanups.
>
> Omit the make_cleanup and have the caller free the memory.
>
> 2014-06-24 Markus Metzger <markus.t.metzger@intel.com>
>
> * fbsd-nat.c (fbsd_make_corefile_notes): Remove make_cleanup call.
> * gcore.c (write_gcore_file): Free memory returned from
> make_corefile_notes.
> * linux-tdep.c (linux_make_corefile_notes): Remove make_cleanup call.
> * procfs.c (procfs_make_note_section): Remove make_cleanup call.
OK.
--
Pedro Alves
next prev parent reply other threads:[~2014-06-24 12:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-24 8:51 Markus Metzger
2014-06-24 8:51 ` [PATCH v2 2/3] gcore, target: allow target to prepare/cleanup for/after core file generation Markus Metzger
2014-06-24 13:11 ` Pedro Alves
2014-06-24 8:52 ` [PATCH v2 3/3] btrace: pretend we're not replaying when generating a core file Markus Metzger
2014-06-24 13:19 ` Pedro Alves
2014-06-24 12:58 ` Pedro Alves [this message]
2014-06-24 13:44 ` [PATCH v2 1/3] make_corefile_notes: have caller free returned memory Tom Tromey
2014-06-24 14:18 ` Metzger, Markus T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A9760B.2060807@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=markus.t.metzger@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox