From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4575 invoked by alias); 24 Jun 2014 12:58:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4564 invoked by uid 89); 24 Jun 2014 12:58:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 24 Jun 2014 12:58:55 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s5OCwrYN023245 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 24 Jun 2014 08:58:53 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s5OCwpOR027251; Tue, 24 Jun 2014 08:58:52 -0400 Message-ID: <53A9760B.2060807@redhat.com> Date: Tue, 24 Jun 2014 12:58:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Markus Metzger CC: gdb-patches@sourceware.org Subject: Re: [PATCH v2 1/3] make_corefile_notes: have caller free returned memory References: <1403599872-25299-1-git-send-email-markus.t.metzger@intel.com> In-Reply-To: <1403599872-25299-1-git-send-email-markus.t.metzger@intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-06/txt/msg00845.txt.bz2 On 06/24/2014 09:51 AM, Markus Metzger wrote: > The various make_corefile_notes implementations for gdbarch as well as target > currently make an xfree cleanup on the data they return. This causes problems > when trying to put a TRY_CATCH around the make_corefile_notes call. > Specifically, we get a stale cleanup error in restore_my_cleanups. > > Omit the make_cleanup and have the caller free the memory. > > 2014-06-24 Markus Metzger > > * fbsd-nat.c (fbsd_make_corefile_notes): Remove make_cleanup call. > * gcore.c (write_gcore_file): Free memory returned from > make_corefile_notes. > * linux-tdep.c (linux_make_corefile_notes): Remove make_cleanup call. > * procfs.c (procfs_make_note_section): Remove make_cleanup call. OK. -- Pedro Alves