From: Pierre Langlois <pierre.langlois@embecosm.com>
To: Pedro Alves <palves@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v3][PR remote/16896] Invalidate a register in cache when a remote target failed to write it.
Date: Fri, 13 Jun 2014 09:14:00 -0000 [thread overview]
Message-ID: <539AC0EB.1050303@embecosm.com> (raw)
In-Reply-To: <5399EEC8.5080904@redhat.com>
>> I was wondering how to go about adding a test for this in
>> the GDB testsuite. Could we include faulty dummy servers to test each packets?"
>
> These two sentences shouldn't really be in the commit log.
>
Yes, absolutely. So what would be the usual way of formatting an email with
adding questions to the mix? I realize this out of the scope of the review so
I'll ask on IRC.
>> + chain_before_invalidate_register =
>> + make_cleanup_regcache_invalidate (regcache, regnum);
>
> I missed this before, but '=' goes on the next line, like:
>
> chain_before_invalidate_register
> = make_cleanup_regcache_invalidate (regcache, regnum);
>
> OK with these changes.
>
> Thanks!
>
Thank you for your review! I'll address the last formatting issue and commit it.
Best,
Pierre
prev parent reply other threads:[~2014-06-13 9:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-12 17:35 Pierre Langlois
2014-06-12 18:17 ` Pedro Alves
2014-06-13 9:14 ` Pierre Langlois [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539AC0EB.1050303@embecosm.com \
--to=pierre.langlois@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox