From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21843 invoked by alias); 13 Jun 2014 09:14:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21828 invoked by uid 89); 13 Jun 2014 09:14:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 X-HELO: mail-wi0-f180.google.com Received: from mail-wi0-f180.google.com (HELO mail-wi0-f180.google.com) (209.85.212.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 13 Jun 2014 09:14:24 +0000 Received: by mail-wi0-f180.google.com with SMTP id hi2so502456wib.1 for ; Fri, 13 Jun 2014 02:14:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=4h8Z+G4/PSR6UwqEOK2JnGXamrtZGQa/X+wrmuJ/OGU=; b=bpZP+OnxHvDeCSjGyS6K5mVOIy0yJLeccYBUb49CM59e8F+XKQygl6KhH4iJFOfcMJ 7FOpoE0rSEbXdltkAnqZ1OlXd1SCNlePzrvo01b+mLorbX+OEBOgHLib81F7DjnpICsB /ge3Kp5WJzLEmKG7IQV/AGNP55EhIRS/qiGik+Y5FicJHR11MlwC7G3Wh5AVwxLGg7pM 6i61uK+oYC4eamNwQdhKl19Gn+LMVbFZj4j1Cogo3jCYwUoZmV5OfVApN79bLMfqcQhb 4xnKIJk2mchFFPRjxf7J+VwZR1DfgeCr/EnxPwjSbYCsQtIc6jhAPODy5CY3H3qea4eO f2Cw== X-Gm-Message-State: ALoCoQmRIAX63P/J8sv6m7Sccn9pnajBCG9ODy2KpK3fI0PO5H386bxikF5H8STz+4A8tSPvtFj3 X-Received: by 10.194.60.35 with SMTP id e3mr2510236wjr.12.1402650861740; Fri, 13 Jun 2014 02:14:21 -0700 (PDT) Received: from [192.168.0.134] (cust64-dsl91-135-5.idnet.net. [91.135.5.64]) by mx.google.com with ESMTPSA id s14sm748014wij.1.2014.06.13.02.14.20 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 13 Jun 2014 02:14:20 -0700 (PDT) Message-ID: <539AC0EB.1050303@embecosm.com> Date: Fri, 13 Jun 2014 09:14:00 -0000 From: Pierre Langlois User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [PATCH v3][PR remote/16896] Invalidate a register in cache when a remote target failed to write it. References: <1402594537-8033-1-git-send-email-pierre.langlois@embecosm.com> <5399EEC8.5080904@redhat.com> In-Reply-To: <5399EEC8.5080904@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-06/txt/msg00531.txt.bz2 >> I was wondering how to go about adding a test for this in >> the GDB testsuite. Could we include faulty dummy servers to test each packets?" > > These two sentences shouldn't really be in the commit log. > Yes, absolutely. So what would be the usual way of formatting an email with adding questions to the mix? I realize this out of the scope of the review so I'll ask on IRC. >> + chain_before_invalidate_register = >> + make_cleanup_regcache_invalidate (regcache, regnum); > > I missed this before, but '=' goes on the next line, like: > > chain_before_invalidate_register > = make_cleanup_regcache_invalidate (regcache, regnum); > > OK with these changes. > > Thanks! > Thank you for your review! I'll address the last formatting issue and commit it. Best, Pierre