From: Pierre Langlois <pierre.langlois@embecosm.com>
To: Pedro Alves <palves@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [RFC][PATCH v2][PR remote/16896] Invalidate a register in cache when a remote target failed to write it.
Date: Thu, 12 Jun 2014 16:03:00 -0000 [thread overview]
Message-ID: <5399CF52.3060901@embecosm.com> (raw)
In-Reply-To: <5399A9CE.4040900@redhat.com>
Hi Pedro,
>> +}
>> +
>> +struct cleanup *
>> +make_cleanup_regcache_invalidate (struct regcache *regcache, int regnum)
>
> As nothing is calling this outside regcache.c, please make it static.
>
Should I exclude make_cleanup_regcache_invalidate from regcache.h as well in
this case?
Thank you for the review! And sorry for the formatting errors.
Best,
Pierre
next prev parent reply other threads:[~2014-06-12 16:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-22 14:23 Pierre Langlois
2014-06-02 9:12 ` [PING][RFC][PATCH " Pierre Langlois
2014-06-11 16:58 ` [PING^2][RFC][PATCH " Pierre Langlois
2014-06-12 13:23 ` [RFC][PATCH " Pedro Alves
2014-06-12 16:03 ` Pierre Langlois [this message]
2014-06-12 16:31 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5399CF52.3060901@embecosm.com \
--to=pierre.langlois@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox