From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17363 invoked by alias); 12 Jun 2014 16:03:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17274 invoked by uid 89); 12 Jun 2014 16:03:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 X-HELO: mail-wi0-f181.google.com Received: from mail-wi0-f181.google.com (HELO mail-wi0-f181.google.com) (209.85.212.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 12 Jun 2014 16:03:35 +0000 Received: by mail-wi0-f181.google.com with SMTP id n3so3276972wiv.14 for ; Thu, 12 Jun 2014 09:03:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=ysHeoC3cAKsXeKCCLEwbSXGfxLZPy9vGccYjYNqpCqg=; b=ljzZqzDkFSE1aWohleeJrL9A7W7rdgrEqaQ9EBW2KR1PBpKG5F80a/bfAL5ysq35ni ZiY76E+g5DwxtZs+RmpX/7CSc2/l1pmVVhiSBhXoQa7zQkYUN4cvUXdtmcaXfjguDwqF lPqz84hEcJxqgS8i6P/cYiI54tOGpTU/QWSiWQ9/OqLTqeu+9iu9SwrSnQHkcG5g+krq r6NQdqgbpRhv4p43zWk9I+deFh5cJNQ06CLKXwa+KRTv6wxnywnOaIR6OYwF430E5Npu 5T80YBTyvmagd+zPARlvR22vAoarGnAqqGRDW+acOjBfm0xXCW61mrdQVpYNtHJoiTjW AgSw== X-Gm-Message-State: ALoCoQls6UvtF5hg9vqwe3Gw2cZXxThoOP4t17xN1F1HC4eXIyTwbSGI8P54HKsR0e9Q3iSQAKuM X-Received: by 10.194.189.116 with SMTP id gh20mr62773448wjc.41.1402589012053; Thu, 12 Jun 2014 09:03:32 -0700 (PDT) Received: from [192.168.0.134] (cust64-dsl91-135-5.idnet.net. [91.135.5.64]) by mx.google.com with ESMTPSA id o12sm14448165wiw.5.2014.06.12.09.03.30 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 12 Jun 2014 09:03:31 -0700 (PDT) Message-ID: <5399CF52.3060901@embecosm.com> Date: Thu, 12 Jun 2014 16:03:00 -0000 From: Pierre Langlois User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [RFC][PATCH v2][PR remote/16896] Invalidate a register in cache when a remote target failed to write it. References: <537E086A.9030803@embecosm.com> <5399A9CE.4040900@redhat.com> In-Reply-To: <5399A9CE.4040900@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-06/txt/msg00507.txt.bz2 Hi Pedro, >> +} >> + >> +struct cleanup * >> +make_cleanup_regcache_invalidate (struct regcache *regcache, int regnum) > > As nothing is calling this outside regcache.c, please make it static. > Should I exclude make_cleanup_regcache_invalidate from regcache.h as well in this case? Thank you for the review! And sorry for the formatting errors. Best, Pierre