From: Pedro Alves <palves@redhat.com>
To: Siva Chandra <sivachandra@google.com>,
gdb-patches <gdb-patches@sourceware.org>
Cc: Ulrich Weigand <uweigand@de.ibm.com>
Subject: Re: [PATCH] Wrap PyObject_Get/HasAttrString in a function with second arg having const qualifier.
Date: Mon, 09 Jun 2014 13:52:00 -0000 [thread overview]
Message-ID: <5395BC0D.50709@redhat.com> (raw)
In-Reply-To: <CAGyQ6gzhoLC3DrxGqx+JaOZzydY4wJbh2zs9cwtN0508C_P26Q@mail.gmail.com>
On 06/09/2014 02:42 PM, Siva Chandra wrote:
> @@ -555,7 +555,7 @@ get_field_flag (PyObject *field, const char *flag_name)
> {
> int flag_value;
> /* Python 2.4 did not have a 'const' here. */
Oh, and this comment is stale here now.
> - PyObject *flag_object = PyObject_GetAttrString (field, (char *) flag_name);
> + PyObject *flag_object = PyObject_GetAttrString (field, flag_name);
--
Pedro Alves
next prev parent reply other threads:[~2014-06-09 13:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-09 13:42 Siva Chandra
2014-06-09 13:49 ` Pedro Alves
2014-06-09 13:52 ` Pedro Alves [this message]
2014-06-10 18:56 ` Siva Chandra
2014-06-10 18:56 ` Siva Chandra
2014-06-11 14:13 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5395BC0D.50709@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=sivachandra@google.com \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox