From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25439 invoked by alias); 9 Jun 2014 13:52:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25428 invoked by uid 89); 9 Jun 2014 13:52:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 09 Jun 2014 13:52:20 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s59DqFCS011679 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 9 Jun 2014 09:52:15 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s59DqEeR002558; Mon, 9 Jun 2014 09:52:14 -0400 Message-ID: <5395BC0D.50709@redhat.com> Date: Mon, 09 Jun 2014 13:52:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Siva Chandra , gdb-patches CC: Ulrich Weigand Subject: Re: [PATCH] Wrap PyObject_Get/HasAttrString in a function with second arg having const qualifier. References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-06/txt/msg00371.txt.bz2 On 06/09/2014 02:42 PM, Siva Chandra wrote: > @@ -555,7 +555,7 @@ get_field_flag (PyObject *field, const char *flag_name) > { > int flag_value; > /* Python 2.4 did not have a 'const' here. */ Oh, and this comment is stale here now. > - PyObject *flag_object = PyObject_GetAttrString (field, (char *) flag_name); > + PyObject *flag_object = PyObject_GetAttrString (field, flag_name); -- Pedro Alves