From: Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
Marcus Shawcroft <Marcus.Shawcroft@arm.com>
Subject: Re: [Patch AArch64] Include asm/ptrace.h in aarch64-linux-nat.c
Date: Thu, 22 May 2014 15:43:00 -0000 [thread overview]
Message-ID: <537E1B20.1090406@arm.com> (raw)
In-Reply-To: <20140522124927.GR22822@adacore.com>
On 05/22/14 13:49, Joel Brobecker wrote:
>> A recent change to glibc removed asm/ptrace.h from user.h for
>> AArch64. This meant that cross-native builds of gdb using trunk
>> glibc broke because aarch64-linux-nat.c because user_hwdebug_state
>> couldn't be found.
>>
>> Fixed by including asm/ptrace.h like other ports.
>
> Thanks for the explanation. Can you make sure you include that
> in the revision history of your commit?
>
>> 2014-05-22 Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>
>>
>> * aarch64-linux-nat.c (asm/ptrace.h): Include.
>>
>
> OK to push. Thank you.
Thanks, pushed.
Ramana
>
next prev parent reply other threads:[~2014-05-22 15:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-22 9:07 Ramana Radhakrishnan
2014-05-22 12:49 ` Joel Brobecker
2014-05-22 15:43 ` Ramana Radhakrishnan [this message]
2014-05-23 8:04 ` Ramana Radhakrishnan
[not found] ` <537F3C6F.7030603@arm.com>
2014-05-23 12:45 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537E1B20.1090406@arm.com \
--to=ramana.radhakrishnan@arm.com \
--cc=Marcus.Shawcroft@arm.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox