From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11973 invoked by alias); 22 May 2014 15:43:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11956 invoked by uid 89); 22 May 2014 15:43:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: collaborate-mta1.arm.com Received: from fw-tnat.austin.arm.com (HELO collaborate-mta1.arm.com) (217.140.110.23) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 22 May 2014 15:43:31 +0000 Received: from [10.1.209.147] (e104577-lin.cambridge.arm.com [10.1.209.147]) by collaborate-mta1.arm.com (Postfix) with ESMTPS id 8A27513F841; Thu, 22 May 2014 10:43:29 -0500 (CDT) Message-ID: <537E1B20.1090406@arm.com> Date: Thu, 22 May 2014 15:43:00 -0000 From: Ramana Radhakrishnan User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:14.0) Gecko/20120713 Thunderbird/14.0 MIME-Version: 1.0 To: Joel Brobecker CC: "gdb-patches@sourceware.org" , Marcus Shawcroft Subject: Re: [Patch AArch64] Include asm/ptrace.h in aarch64-linux-nat.c References: <537DBDF3.1080907@arm.com> <20140522124927.GR22822@adacore.com> In-Reply-To: <20140522124927.GR22822@adacore.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2014-05/txt/msg00553.txt.bz2 On 05/22/14 13:49, Joel Brobecker wrote: >> A recent change to glibc removed asm/ptrace.h from user.h for >> AArch64. This meant that cross-native builds of gdb using trunk >> glibc broke because aarch64-linux-nat.c because user_hwdebug_state >> couldn't be found. >> >> Fixed by including asm/ptrace.h like other ports. > > Thanks for the explanation. Can you make sure you include that > in the revision history of your commit? > >> 2014-05-22 Ramana Radhakrishnan >> >> * aarch64-linux-nat.c (asm/ptrace.h): Include. >> > > OK to push. Thank you. Thanks, pushed. Ramana >