From: Pedro Alves <palves@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [patch] linux_nat_kill() compat. with linux-2.4.x
Date: Wed, 21 May 2014 12:49:00 -0000 [thread overview]
Message-ID: <537CA0E7.6010505@redhat.com> (raw)
In-Reply-To: <20140316135916.GA31463@host2.jankratochvil.net>
Hi Jan,
On 03/16/2014 01:59 PM, Jan Kratochvil wrote:
> gdb/
> 2014-03-16 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> PR gdb/15358
> * linux-nat.c (linux_nat_kill): Use kill_callback first.
> Extend the comment for stop_callback.
>
> diff --git a/gdb/linux-nat.c b/gdb/linux-nat.c
> index b615423..ec84188 100644
> --- a/gdb/linux-nat.c
> +++ b/gdb/linux-nat.c
> @@ -3777,8 +3777,15 @@ linux_nat_kill (struct target_ops *ops)
> {
> ptid_t ptid = pid_to_ptid (ptid_get_pid (inferior_ptid));
>
> + /* Kill all LWP's before trying to stop them. In rare cases the
> + lwp_info state may not match the inferior and
> + stop_wait_callback could lock up. */
Hmm, I find this comment confusing and not really enlightening.
What sort of rare cases? It that PR15713? Best just fix that.
I've sent a patch:
https://sourceware.org/ml/gdb-patches/2014-05/msg00473.html
--
Pedro Alves
next prev parent reply other threads:[~2014-05-21 12:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-16 13:59 Jan Kratochvil
2014-05-21 12:49 ` Pedro Alves [this message]
2014-06-06 20:15 ` Jan Kratochvil
2014-06-09 10:29 ` Pedro Alves
2014-06-09 10:32 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537CA0E7.6010505@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox