From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23894 invoked by alias); 21 May 2014 12:49:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23761 invoked by uid 89); 21 May 2014 12:49:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 May 2014 12:49:46 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4LCniSQ031676 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 21 May 2014 08:49:45 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s4LCnhkc010060; Wed, 21 May 2014 08:49:44 -0400 Message-ID: <537CA0E7.6010505@redhat.com> Date: Wed, 21 May 2014 12:49:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Jan Kratochvil , gdb-patches@sourceware.org Subject: Re: [patch] linux_nat_kill() compat. with linux-2.4.x References: <20140316135916.GA31463@host2.jankratochvil.net> In-Reply-To: <20140316135916.GA31463@host2.jankratochvil.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-05/txt/msg00474.txt.bz2 Hi Jan, On 03/16/2014 01:59 PM, Jan Kratochvil wrote: > gdb/ > 2014-03-16 Jan Kratochvil > > PR gdb/15358 > * linux-nat.c (linux_nat_kill): Use kill_callback first. > Extend the comment for stop_callback. > > diff --git a/gdb/linux-nat.c b/gdb/linux-nat.c > index b615423..ec84188 100644 > --- a/gdb/linux-nat.c > +++ b/gdb/linux-nat.c > @@ -3777,8 +3777,15 @@ linux_nat_kill (struct target_ops *ops) > { > ptid_t ptid = pid_to_ptid (ptid_get_pid (inferior_ptid)); > > + /* Kill all LWP's before trying to stop them. In rare cases the > + lwp_info state may not match the inferior and > + stop_wait_callback could lock up. */ Hmm, I find this comment confusing and not really enlightening. What sort of rare cases? It that PR15713? Best just fix that. I've sent a patch: https://sourceware.org/ml/gdb-patches/2014-05/msg00473.html -- Pedro Alves