From: Pedro Alves <palves@redhat.com>
To: Simon Marchi <simon.marchi@ericsson.com>, Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2] Fix argument passing in mi_run_cmd_full
Date: Wed, 21 May 2014 08:46:00 -0000 [thread overview]
Message-ID: <537C67DA.2080606@redhat.com> (raw)
In-Reply-To: <537BD614.5030600@ericsson.com>
On 05/20/2014 11:24 PM, Simon Marchi wrote:
> In my opinion, I think the old behavior was fine, it just needs to be documented better (clarify what $args means in the mi_run_* procedures).
I agree, because it's also the simplest, and as you say,
> I ended up not even using this fix, since Pedro suggested that to modify
> the behavior of a test program, I should stop at a breakpoint and modify
> the value of a global variable instead.
nothing is actually making use of the original fix.
If we end up needing to pass program arguments to mi_run_cmd
in MI mode, we can revisit.
Thanks,
--
Pedro Alves
prev parent reply other threads:[~2014-05-21 8:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-13 21:47 Simon Marchi
2014-05-15 18:40 ` Tom Tromey
2014-05-15 19:47 ` Simon Marchi
2014-05-19 19:39 ` Tom Tromey
2014-05-20 16:40 ` Simon Marchi
2014-05-20 22:24 ` Simon Marchi
2014-05-21 8:46 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537C67DA.2080606@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox