From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10271 invoked by alias); 21 May 2014 08:46:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10259 invoked by uid 89); 21 May 2014 08:46:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 May 2014 08:46:24 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4L8kKBM028698 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 21 May 2014 04:46:20 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s4L8kJif025917; Wed, 21 May 2014 04:46:19 -0400 Message-ID: <537C67DA.2080606@redhat.com> Date: Wed, 21 May 2014 08:46:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Simon Marchi , Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: [PATCH v2] Fix argument passing in mi_run_cmd_full References: <1400017636-28020-1-git-send-email-simon.marchi@ericsson.com> <87ha4lwobm.fsf@fleche.redhat.com> <537B8561.6010603@ericsson.com> <537BD614.5030600@ericsson.com> In-Reply-To: <537BD614.5030600@ericsson.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-05/txt/msg00462.txt.bz2 On 05/20/2014 11:24 PM, Simon Marchi wrote: > In my opinion, I think the old behavior was fine, it just needs to be documented better (clarify what $args means in the mi_run_* procedures). I agree, because it's also the simplest, and as you say, > I ended up not even using this fix, since Pedro suggested that to modify > the behavior of a test program, I should stop at a breakpoint and modify > the value of a global variable instead. nothing is actually making use of the original fix. If we end up needing to pass program arguments to mi_run_cmd in MI mode, we can revisit. Thanks, -- Pedro Alves