Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>, gdb-patches@sourceware.org
Cc: Joel Brobecker <brobecker@adacore.com>,
	Sergio Durigan Junior <sergiodj@redhat.com>
Subject: Re: [patch+8.0] release branch: Fix: --enable-werror
Date: Fri, 21 Apr 2017 14:04:00 -0000	[thread overview]
Message-ID: <5365d856-2d9d-9017-a133-2499ba644e9d@redhat.com> (raw)
In-Reply-To: <20170421085204.GA5501@host1.jankratochvil.net>

On 04/21/2017 09:52 AM, Jan Kratochvil wrote:
> Hi,
> 
> gdb-8.0-branch
> ./configure --enable-werror --enable-targets=all
> aarch64-tdep.c:3045:13: error: ‘void selftests::aarch64_process_record_test()’ declared ‘static’ but never defined [-Werror=unused-function]
> arm-tdep.c:9601:13: error: ‘void selftests::arm_record_test()’ declared ‘static’ but never defined [-Werror=unused-function]
> 
> OK for check-in?

OK.

> 
> Please do not tell me release branches do not support --enable-werror as this
> is due to a sourcebase bug, not due to some unexpected compiler
> incompatibility.

Certainly.

> Sergio: Shouldn't it be also buildbot-tested?

Sounds like a good idea.

Thanks,
Pedro Alves


  reply	other threads:[~2017-04-21 14:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-21  8:52 Jan Kratochvil
2017-04-21 14:04 ` Pedro Alves [this message]
2017-04-21 14:18   ` [commit+8.0] " Jan Kratochvil
2017-04-22 16:20 ` Sergio Durigan Junior
2017-04-22 16:34   ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5365d856-2d9d-9017-a133-2499ba644e9d@redhat.com \
    --to=palves@redhat.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    --cc=sergiodj@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox