From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 68385 invoked by alias); 21 Apr 2017 14:04:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 68355 invoked by uid 89); 21 Apr 2017 14:04:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 21 Apr 2017 14:03:55 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7DE321602BD; Fri, 21 Apr 2017 14:03:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7DE321602BD Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 7DE321602BD Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0A0CC80DE3; Fri, 21 Apr 2017 14:03:50 +0000 (UTC) Subject: Re: [patch+8.0] release branch: Fix: --enable-werror To: Jan Kratochvil , gdb-patches@sourceware.org References: <20170421085204.GA5501@host1.jankratochvil.net> Cc: Joel Brobecker , Sergio Durigan Junior From: Pedro Alves Message-ID: <5365d856-2d9d-9017-a133-2499ba644e9d@redhat.com> Date: Fri, 21 Apr 2017 14:04:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170421085204.GA5501@host1.jankratochvil.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-SW-Source: 2017-04/txt/msg00609.txt.bz2 On 04/21/2017 09:52 AM, Jan Kratochvil wrote: > Hi, > > gdb-8.0-branch > ./configure --enable-werror --enable-targets=all > aarch64-tdep.c:3045:13: error: ‘void selftests::aarch64_process_record_test()’ declared ‘static’ but never defined [-Werror=unused-function] > arm-tdep.c:9601:13: error: ‘void selftests::arm_record_test()’ declared ‘static’ but never defined [-Werror=unused-function] > > OK for check-in? OK. > > Please do not tell me release branches do not support --enable-werror as this > is due to a sourcebase bug, not due to some unexpected compiler > incompatibility. Certainly. > Sergio: Shouldn't it be also buildbot-tested? Sounds like a good idea. Thanks, Pedro Alves