Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Michael Sturm <michael.sturm@intel.com>
Cc: palves@redhat.com, eliz@gnu.org, mark.kettenis@xs4all.nl,
	       walfred.tedeschi@intel.com, gdb-patches@sourceware.org
Subject: Re: [PATCH V5 0/3] Intel(R) AVX-512 register support
Date: Thu, 24 Apr 2014 11:49:00 -0000	[thread overview]
Message-ID: <5358FA29.4010607@redhat.com> (raw)
In-Reply-To: <1398258160-9070-1-git-send-email-michael.sturm@intel.com>

On 04/23/2014 02:02 PM, Michael Sturm wrote:
> Pedro,
> 
> thanks for your review. We've addressed the comments you made regarding the 
> test case and the manual content. We do agree to your comment 
> regarding sharing code between GDB and GDBserver. We would prefer to
> make this change in a patch dedicated to unify XSAVE buffer access 
> between GDB and GDBserver.
> Would you agree to that and approve committing this series?

Definitely.  I wasn't suggesting making that as part of this patch.

Oh,

> This patch series adds support for the Intel(R) Advanced Vector Extensions 512
> (Intel(R) AVX-512) registers. Native and remote debugging are covered by this
> patch series.
> 
> Intel(R) AVX-512 is an extension to AVX to support 512-bit wide SIMD registers
> in 64-bit mode (XMM0-XMM31, YMM0-YMM31, ZMM0-ZMM31). The number of available
> registers in 32-bit mode is still 8 (XMM0-7, YMM0-7, ZMM0-7). The lower
> 256-bits of the ZMM registers are aliased to the respective 256-bit YMM
> registers. The lower 128-bits are aliased to the respective 128-bit XMM
> registers.
> 
> There are also 8 new, dedicated mask registers (K0-K7) in both 32-bit mode
> and 64-bit mode.
> 
> For more information please see
> Intel(R) Developer Zone: Intel(R) AVX
> http://software.intel.com/en-us/intel-isa-extensions#pid-16007-1495
> 
> Intel(R) Architecture Instruction Set Extensions Programming Reference:
> http://software.intel.com/en-us/file/319433-017pdf

I notice that this info is only in the series cover letter, which
never makes it to the commit log.  Would you mind putting it in at
least the commit log entry of the GDB patch (tweaked a little to
not say "series")?  (pre-approved, no need for another round
of review for that).

Thanks,
-- 
Pedro Alves


      parent reply	other threads:[~2014-04-24 11:49 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-23 13:03 Michael Sturm
2014-04-23 13:03 ` [PATCH V5 3/3] Add AVX512 feature description to GDB manual Michael Sturm
2013-12-03 12:37   ` [PATCH v3 1/1] Documentation for MPX Walfred Tedeschi
2013-12-03 12:52     ` Eli Zaretskii
2014-08-04 16:57     ` Incorrect placement of two Intel gdb/NEWS items Jan Kratochvil
2014-08-04 19:17       ` Eli Zaretskii
2014-08-04 19:40         ` [commit+7.8] " Jan Kratochvil
2014-04-23 13:03 ` [PATCH V5 2/3] Add AVX512 register support to gdbserver Michael Sturm
2014-11-21 10:21   ` Andreas Arnez
2014-12-13 13:41     ` Joel Brobecker
2015-01-08 10:01       ` Sturm, Michael
2015-01-10  7:00         ` Joel Brobecker
2014-04-23 13:04 ` [PATCH V5 1/3] Add AVX512 registers support to GDB Michael Sturm
2014-04-24 11:33   ` Pedro Alves
2014-04-24 11:48   ` Pedro Alves
2014-04-24 11:49 ` Pedro Alves [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5358FA29.4010607@redhat.com \
    --to=palves@redhat.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=mark.kettenis@xs4all.nl \
    --cc=michael.sturm@intel.com \
    --cc=walfred.tedeschi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox