From: Keith Seitz <keiths@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: "gdb-patches@sourceware.org ml" <gdb-patches@sourceware.org>
Subject: Re: [RFA testsuite 5/5] Update all callers
Date: Wed, 23 Apr 2014 19:01:00 -0000 [thread overview]
Message-ID: <53580E1E.4020109@redhat.com> (raw)
In-Reply-To: <87ppkflm55.fsf@fleche.redhat.com>
On 04/17/2014 01:46 PM, Tom Tromey wrote:
>>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
>
> Keith> 2014-04-15 Keith Seitz <keiths@redhat.com>
> Keith> * gdb.mi/mi-break.exp: Remove unused globals,
> Keith> update mi_create_breakpoint usage, and use mi_make_breakpoint_table.
> Keith> All callers updated.
> Keith> * gdb.mi/mi-dprintf.exp: Use variable to track command
> Keith> number.
> Keith> Update all callers of mi_create_breakpoint and use
> Keith> mi_make_breakpoint_table.
> Keith> Remove any unused global variables.
> Keith> * gdb.mi/mi-nonstop.exp: Likewise.
> Keith> * gdb.mi/mi-nsintrall.exp: Likewise.
> Keith> * gdb.mi/mi-nsmoribund.exp: Likewise.
> Keith> * gdb.mi/mi-nsthrexec.exp: Likewise.
> Keith> * gdb.mi/mi-reverse.exp: Likewise.
> Keith> * gdb.mi/mi-simplerun.exp: Likewise.
> Keith> * gdb.mi/mi-stepn.exp: Likewise.
> Keith> * gdb.mi/mi-syn-frame.exp: Likewise.
> Keith> * gdb.mi/mi-until.exp: Likewise.
> Keith> * gdb.mi/mi-var-cp.exp: Likewise.
> Keith> * gdb.mi/mi-var-display.exp: Likewise.
> Keith> * gdb.mi/mi2-amd64-entry-value.exp: Likewise.
> Keith> * gdb.mi/mi2-var-child.exp: Likewise.
> Keith> * lib/mi-support.exp: Likewise.
>
> This is ok.
Recently a new test using mi_create_breakpoint was introduced. I'll be
pushing this (as obvious) when I commit the whole series.
Keith
diff --git a/gdb/testsuite/gdb.mi/mi-vla-c99.exp
b/gdb/testsuite/gdb.mi/mi-vla-c99.exp
index 618e8ab..ee78700 100644
--- a/gdb/testsuite/gdb.mi/mi-vla-c99.exp
+++ b/gdb/testsuite/gdb.mi/mi-vla-c99.exp
@@ -40,9 +40,10 @@ mi_gdb_load ${binfile}
set bp_lineno [gdb_get_line_number "vla-filled"]
-mi_create_breakpoint "-t vla.c:$bp_lineno" 1 "del" "func" \
- ".*vla.c" $bp_lineno $hex \
- "insert breakpoint at line $bp_lineno after vla is filled"
+mi_create_breakpoint "-t vla.c:$bp_lineno" \
+ "insert breakpoint at line $bp_lineno after vla is filled" \
+ -function func -line $bp_lineno -file ".*vla.c" -disp del
+
mi_run_cmd
mi_expect_stop "breakpoint-hit" "func" "\{name=\"n\",value=\"5\"\}" \
".*vla.c" "$bp_lineno" { "" "disp=\"del\"" } \
testsuite/ChangeLog
2014-04-23 Keith Seitz <keiths@redhat.com>
* gdb.mi/mi-vla-c99.exp: Update mi_create_breakpoint usage.
next prev parent reply other threads:[~2014-04-23 19:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-16 18:53 Keith Seitz
2014-04-17 20:46 ` Tom Tromey
2014-04-23 19:01 ` Keith Seitz [this message]
2014-04-23 19:36 ` Keith Seitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53580E1E.4020109@redhat.com \
--to=keiths@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox