From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29466 invoked by alias); 23 Apr 2014 19:01:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29455 invoked by uid 89); 23 Apr 2014 19:01:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 23 Apr 2014 19:01:54 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s3NJ1pQP007128 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 23 Apr 2014 15:01:52 -0400 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s3NJ1o4n027266 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 23 Apr 2014 15:01:51 -0400 Message-ID: <53580E1E.4020109@redhat.com> Date: Wed, 23 Apr 2014 19:01:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Tom Tromey CC: "gdb-patches@sourceware.org ml" Subject: Re: [RFA testsuite 5/5] Update all callers References: <534ED199.3050004@redhat.com> <87ppkflm55.fsf@fleche.redhat.com> In-Reply-To: <87ppkflm55.fsf@fleche.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-04/txt/msg00463.txt.bz2 On 04/17/2014 01:46 PM, Tom Tromey wrote: >>>>>> "Keith" == Keith Seitz writes: > > Keith> 2014-04-15 Keith Seitz > Keith> * gdb.mi/mi-break.exp: Remove unused globals, > Keith> update mi_create_breakpoint usage, and use mi_make_breakpoint_table. > Keith> All callers updated. > Keith> * gdb.mi/mi-dprintf.exp: Use variable to track command > Keith> number. > Keith> Update all callers of mi_create_breakpoint and use > Keith> mi_make_breakpoint_table. > Keith> Remove any unused global variables. > Keith> * gdb.mi/mi-nonstop.exp: Likewise. > Keith> * gdb.mi/mi-nsintrall.exp: Likewise. > Keith> * gdb.mi/mi-nsmoribund.exp: Likewise. > Keith> * gdb.mi/mi-nsthrexec.exp: Likewise. > Keith> * gdb.mi/mi-reverse.exp: Likewise. > Keith> * gdb.mi/mi-simplerun.exp: Likewise. > Keith> * gdb.mi/mi-stepn.exp: Likewise. > Keith> * gdb.mi/mi-syn-frame.exp: Likewise. > Keith> * gdb.mi/mi-until.exp: Likewise. > Keith> * gdb.mi/mi-var-cp.exp: Likewise. > Keith> * gdb.mi/mi-var-display.exp: Likewise. > Keith> * gdb.mi/mi2-amd64-entry-value.exp: Likewise. > Keith> * gdb.mi/mi2-var-child.exp: Likewise. > Keith> * lib/mi-support.exp: Likewise. > > This is ok. Recently a new test using mi_create_breakpoint was introduced. I'll be pushing this (as obvious) when I commit the whole series. Keith diff --git a/gdb/testsuite/gdb.mi/mi-vla-c99.exp b/gdb/testsuite/gdb.mi/mi-vla-c99.exp index 618e8ab..ee78700 100644 --- a/gdb/testsuite/gdb.mi/mi-vla-c99.exp +++ b/gdb/testsuite/gdb.mi/mi-vla-c99.exp @@ -40,9 +40,10 @@ mi_gdb_load ${binfile} set bp_lineno [gdb_get_line_number "vla-filled"] -mi_create_breakpoint "-t vla.c:$bp_lineno" 1 "del" "func" \ - ".*vla.c" $bp_lineno $hex \ - "insert breakpoint at line $bp_lineno after vla is filled" +mi_create_breakpoint "-t vla.c:$bp_lineno" \ + "insert breakpoint at line $bp_lineno after vla is filled" \ + -function func -line $bp_lineno -file ".*vla.c" -disp del + mi_run_cmd mi_expect_stop "breakpoint-hit" "func" "\{name=\"n\",value=\"5\"\}" \ ".*vla.c" "$bp_lineno" { "" "disp=\"del\"" } \ testsuite/ChangeLog 2014-04-23 Keith Seitz * gdb.mi/mi-vla-c99.exp: Update mi_create_breakpoint usage.