Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <yao@codesourcery.com>
To: <gdb-patches@sourceware.org>
Subject: Re: [PATCH] [testsuite] Disable Ctrl-V use for mingw hosts.
Date: Tue, 01 Apr 2014 02:26:00 -0000	[thread overview]
Message-ID: <533A2362.3030405@codesourcery.com> (raw)
In-Reply-To: <1395712934-29531-1-git-send-email-yao@codesourcery.com>

On 03/25/2014 10:02 AM, Yao Qi wrote:
> On mingw host, we have seen two fails as below,
> 
> p int1dim[0]^V@2
> Invalid character '^V' in expression.
> (gdb) FAIL: gdb.base/printcmds.exp: p int1dim[0]@2
> p int1dim[0]^V@2^V@3
> Invalid character '^V' in expression.
> (gdb) FAIL: gdb.base/printcmds.exp: p int1dim[0]@2@3
> 
> In the test, the comment says "# Send \026@ instead of just @ in case
> the kill character is @".  Historically, kill character was @, and
> Ctrl-V (\026) is to escape the next character.  However, we don't have
> to do so on mingw.  This patch is to disable ctrl-v usage on mingw
> hots.  With this patch applied, it becomes:
> 
> p int1dim[0]@2
> $607 = {0, 1}
> (gdb) PASS: gdb.base/printcmds.exp: p int1dim[0]@2
> p int1dim[0]@2@3
> $608 = {{0, 1}, {2, 3}, {4, 5}}
> 
> Note that this patch is picked from Pierre's submission,
> 
>   [RFC 6/6] Fix remaining failures in gdb.base/printcmds.exp for mingw hosts.
>   https://www.sourceware.org/ml/gdb-patches/2013-09/msg00943.html
> 
> gdb/testsuite:
> 
> 2014-03-25  Pierre Muller  <muller@sourceware.org>
> 
> 	* gdb.base/printcmds.exp (test_artificial_arrays): Disable
> 	Ctrl-V use for mingw hosts.

Ping.  https://sourceware.org/ml/gdb-patches/2014-03/msg00590.html

-- 
Yao (齐尧)


  reply	other threads:[~2014-04-01  2:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-25  2:05 Yao Qi
2014-04-01  2:26 ` Yao Qi [this message]
2014-04-07 16:39   ` Joel Brobecker
2014-04-08  6:07     ` Yao Qi
2014-04-08  8:09       ` Pierre Muller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=533A2362.3030405@codesourcery.com \
    --to=yao@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox