From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23189 invoked by alias); 1 Apr 2014 02:26:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23175 invoked by uid 89); 1 Apr 2014 02:26:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 01 Apr 2014 02:26:45 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1WUoPR-0003Qi-Ta from Yao_Qi@mentor.com for gdb-patches@sourceware.org; Mon, 31 Mar 2014 19:26:41 -0700 Received: from SVR-ORW-FEM-05.mgc.mentorg.com ([147.34.97.43]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Mon, 31 Mar 2014 19:26:41 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-05.mgc.mentorg.com (147.34.97.43) with Microsoft SMTP Server id 14.2.247.3; Mon, 31 Mar 2014 19:24:45 -0700 Message-ID: <533A2362.3030405@codesourcery.com> Date: Tue, 01 Apr 2014 02:26:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Subject: Re: [PATCH] [testsuite] Disable Ctrl-V use for mingw hosts. References: <1395712934-29531-1-git-send-email-yao@codesourcery.com> In-Reply-To: <1395712934-29531-1-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2014-04/txt/msg00001.txt.bz2 On 03/25/2014 10:02 AM, Yao Qi wrote: > On mingw host, we have seen two fails as below, > > p int1dim[0]^V@2 > Invalid character '^V' in expression. > (gdb) FAIL: gdb.base/printcmds.exp: p int1dim[0]@2 > p int1dim[0]^V@2^V@3 > Invalid character '^V' in expression. > (gdb) FAIL: gdb.base/printcmds.exp: p int1dim[0]@2@3 > > In the test, the comment says "# Send \026@ instead of just @ in case > the kill character is @". Historically, kill character was @, and > Ctrl-V (\026) is to escape the next character. However, we don't have > to do so on mingw. This patch is to disable ctrl-v usage on mingw > hots. With this patch applied, it becomes: > > p int1dim[0]@2 > $607 = {0, 1} > (gdb) PASS: gdb.base/printcmds.exp: p int1dim[0]@2 > p int1dim[0]@2@3 > $608 = {{0, 1}, {2, 3}, {4, 5}} > > Note that this patch is picked from Pierre's submission, > > [RFC 6/6] Fix remaining failures in gdb.base/printcmds.exp for mingw hosts. > https://www.sourceware.org/ml/gdb-patches/2013-09/msg00943.html > > gdb/testsuite: > > 2014-03-25 Pierre Muller > > * gdb.base/printcmds.exp (test_artificial_arrays): Disable > Ctrl-V use for mingw hosts. Ping. https://sourceware.org/ml/gdb-patches/2014-03/msg00590.html -- Yao (齐尧)