From: Pierre Langlois <pierre.langlois@embecosm.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH][PR/backtrace 16721] Fix erroneous backtrace on AVR
Date: Fri, 21 Mar 2014 13:23:00 -0000 [thread overview]
Message-ID: <532C3D3B.7040509@embecosm.com> (raw)
In-Reply-To: <20140319123423.GF4282@adacore.com>
Hi Joel,
Sorry for the late reply.
> Now that Tristan approved the patch, do you have an FSF copyright
> assignment on file? This patch is small that we can push it in without;
> but if you are planning on sending more, you'll need one. Just let me
> know and I will get you a message to get you started (it takes a while
> to complete, so the sooner the better).
I am doing this work on behalf of Embecosm, we have an FSF copyright assignment
on file.
> One remark on the ChangeLog; the formatting is off a bit. It should be
> indented by one tab, and the indentation should be the same, regardless
> of whether the line starts with a '*' or not - no extra indentation
> for continuation lines. Thus:
>
> * avr-tdep.c (avr_scan_prologue): Accept push r1 instruction for small
> stack allocation.
>
> (in emails, it's not important to be using 8 spaces or 1 tab, but in
> the CL, we tend to be picky about it).
I'll make sure my email client is properly configured next time.
Thank you very much!
Pierre
next prev parent reply other threads:[~2014-03-21 13:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-18 17:53 Pierre Langlois
2014-03-19 8:00 ` Tristan Gingold
2014-03-19 12:34 ` Joel Brobecker
2014-03-21 13:23 ` Pierre Langlois [this message]
2014-03-21 17:20 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532C3D3B.7040509@embecosm.com \
--to=pierre.langlois@embecosm.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox