From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21690 invoked by alias); 21 Mar 2014 13:23:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21668 invoked by uid 89); 21 Mar 2014 13:23:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 X-HELO: mail-wg0-f48.google.com Received: from mail-wg0-f48.google.com (HELO mail-wg0-f48.google.com) (74.125.82.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 21 Mar 2014 13:23:12 +0000 Received: by mail-wg0-f48.google.com with SMTP id l18so1621353wgh.7 for ; Fri, 21 Mar 2014 06:23:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=86httE6SylKdBjNd1BynwZuU7V7G7E9/PXXYXFg/Qgw=; b=dN/o9RdaiWdkKXTCMlYOXX3pczWa9UrhB0Mkc3bzhV3KSFQZbVLZt1kyKSL+B9SY8b d4vMBhBQteigw7uTcCwPJf8DdHn84lcvIjiAi23voGUM4FTSRVIdA5VuWy8HLyPLOvfE lAdxrcmUXMb+fOVXqR+Ga4SVsuDLsMll1q+O4or3dZNQfX3xGJ0rAB+FS/Ha6upmizqD WK9nzm0xPWyiDDhyasaC11FZDNprOnPt6+BcdvjXPHEYu+1FyWoljL1H5ahk7VgyoAE9 GGPDBIic00tGJuysOQl10Y43OF+gmVspTcTWpe1aVKwlVCcj1YfNHA5u/WoHbjIcH/er Q/Ww== X-Gm-Message-State: ALoCoQmsFW4qLWTXvNu4vHnCaFp8puFPUwb9bXjLnPIZgX3XlsZ45besbM1bZhqCjb0RY+1pzMIm X-Received: by 10.194.19.161 with SMTP id g1mr37843201wje.20.1395408189752; Fri, 21 Mar 2014 06:23:09 -0700 (PDT) Received: from [192.168.0.134] (cust64-dsl91-135-5.idnet.net. [91.135.5.64]) by mx.google.com with ESMTPSA id fs8sm4790618wib.8.2014.03.21.06.23.08 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 21 Mar 2014 06:23:08 -0700 (PDT) Message-ID: <532C3D3B.7040509@embecosm.com> Date: Fri, 21 Mar 2014 13:23:00 -0000 From: Pierre Langlois User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: Joel Brobecker CC: gdb-patches@sourceware.org Subject: Re: [PATCH][PR/backtrace 16721] Fix erroneous backtrace on AVR References: <53288819.7080903@embecosm.com> <20140319123423.GF4282@adacore.com> In-Reply-To: <20140319123423.GF4282@adacore.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-03/txt/msg00522.txt.bz2 Hi Joel, Sorry for the late reply. > Now that Tristan approved the patch, do you have an FSF copyright > assignment on file? This patch is small that we can push it in without; > but if you are planning on sending more, you'll need one. Just let me > know and I will get you a message to get you started (it takes a while > to complete, so the sooner the better). I am doing this work on behalf of Embecosm, we have an FSF copyright assignment on file. > One remark on the ChangeLog; the formatting is off a bit. It should be > indented by one tab, and the indentation should be the same, regardless > of whether the line starts with a '*' or not - no extra indentation > for continuation lines. Thus: > > * avr-tdep.c (avr_scan_prologue): Accept push r1 instruction for small > stack allocation. > > (in emails, it's not important to be using 8 spaces or 1 tab, but in > the CL, we tend to be picky about it). I'll make sure my email client is properly configured next time. Thank you very much! Pierre