From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC v5 1/8] fix latent bugs in ui-out.c
Date: Mon, 17 Mar 2014 19:16:00 -0000 [thread overview]
Message-ID: <53274A11.2010101@redhat.com> (raw)
In-Reply-To: <1393957974-4521-2-git-send-email-tromey@redhat.com>
Hi,
On 03/04/2014 06:32 PM, Tom Tromey wrote:
> The destructor code in ui-out.c has a latent bug, which is hidden by
> the fact that nothing uses this right now. This patch fixes the
> problem. The bug is that we don't always clear a pointer in the
> ui-out object, leading to a bad free.
>
> 2013-10-30 Tom Tromey <tromey@redhat.com>
>
> * ui-out.c (clear_table, ui_out_new): Clear uiout->table.id.
This one is obviously correct. There's really no need
to hold it further, so I went ahead and pushed it in.
Thanks,
--
Pedro Alves
next prev parent reply other threads:[~2014-03-17 19:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 18:33 [RFC v5 0/8] enable target-async by default Tom Tromey
2014-03-04 18:33 ` [RFC v5 8/8] " Tom Tromey
2014-03-04 18:33 ` [RFC v5 3/8] PR gdb/13860: make "-exec-foo"'s MI output equal to "foo"'s MI output Tom Tromey
2014-03-04 18:33 ` [RFC v5 2/8] PR gdb/13860: make -interpreter-exec console "list" behave more like "list" Tom Tromey
2014-03-18 16:04 ` [RFC v6] " Pedro Alves
2014-05-21 22:16 ` Pedro Alves
2014-03-04 18:33 ` [RFC v5 5/8] make dprintf.exp pass in always-async mode Tom Tromey
2014-03-20 18:04 ` Pedro Alves
2014-03-04 18:33 ` [RFC v5 1/8] fix latent bugs in ui-out.c Tom Tromey
2014-03-17 19:16 ` Pedro Alves [this message]
2014-03-04 18:33 ` [RFC v5 7/8] separate MI and target notions of async Tom Tromey
2014-03-04 18:40 ` Eli Zaretskii
2014-03-04 19:11 ` Tom Tromey
2014-05-23 20:45 ` Pedro Alves
2014-03-04 18:33 ` [RFC v5 4/8] PR gdb/13860: don't lose '-interpreter-exec console EXECUTION_COMMAND''s output in async mode Tom Tromey
2014-03-18 19:01 ` [RFC v6 " Pedro Alves
2014-05-21 22:37 ` Pedro Alves
2014-03-04 18:40 ` [RFC v5 6/8] fix py-finish-breakpoint.exp with always-async Tom Tromey
2014-03-20 18:28 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53274A11.2010101@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox