From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26376 invoked by alias); 17 Mar 2014 19:16:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26363 invoked by uid 89); 17 Mar 2014 19:16:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 17 Mar 2014 19:16:39 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s2HJGa9M013469 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 17 Mar 2014 15:16:37 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s2HJGY9R001610; Mon, 17 Mar 2014 15:16:35 -0400 Message-ID: <53274A11.2010101@redhat.com> Date: Mon, 17 Mar 2014 19:16:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: [RFC v5 1/8] fix latent bugs in ui-out.c References: <1393957974-4521-1-git-send-email-tromey@redhat.com> <1393957974-4521-2-git-send-email-tromey@redhat.com> In-Reply-To: <1393957974-4521-2-git-send-email-tromey@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-03/txt/msg00396.txt.bz2 Hi, On 03/04/2014 06:32 PM, Tom Tromey wrote: > The destructor code in ui-out.c has a latent bug, which is hidden by > the fact that nothing uses this right now. This patch fixes the > problem. The bug is that we don't always clear a pointer in the > ui-out object, leading to a bad free. > > 2013-10-30 Tom Tromey > > * ui-out.c (clear_table, ui_out_new): Clear uiout->table.id. This one is obviously correct. There's really no need to hold it further, so I went ahead and pushed it in. Thanks, -- Pedro Alves